Skip to contentSkip to conversation

anyone including <linux/perf_counter.h>?

DISCUSSION Robert P. J. Day 2 participants 7 messages Dec 16, 2009

lore
Share & tools
lore
#0 lore raw

just prepping to run my cleanup suggestion scripts after the merge
window closes, quick test run on some scripts and ran across the fact that no one appears to be including <linux/perf_counter.h>.

any value to that file? just curious. much more pedantry after the
merge window, of course.

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================

#1 lore raw
Quoted 8 lines · Robert P. J. Day

just prepping to run my cleanup suggestion scripts after the merge
window closes, quick test run on some scripts and ran across the fact that no one appears to be including <linux/perf_counter.h>.

any value to that file? just curious. much more pedantry after the
merge window, of course.

See the comment at the top, it's being provided to provide the old names to userspace for a short time, now that the functionality has been renamed to perf_events.

--kyle

#2 lore raw
Quoted 6 lines · Kyle McMartin
Quoted 5 lines · Robert P. J. Day

just prepping to run my cleanup suggestion scripts after the merge
window closes, quick test run on some scripts and ran across the fact that no one appears to be including <linux/perf_counter.h>.

Quoted 6 lines
Quoted 2 lines

any value to that file? just curious. much more pedantry after the
merge window, of course.

See the comment at the top, it's being provided to provide the old names to userspace for a short time, now that the functionality has been renamed to perf_events.

but if it's supposed to be providing info to user-space, shouldn't
it be *exported* to user space? it's not listed in include/linux/Kbuild. or am i misunderstanding?

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================

#3 lore raw
Quoted 8 lines · Robert P. J. Day
Quoted 3 lines

See the comment at the top, it's being provided to provide the old names to userspace for a short time, now that the functionality has been renamed to perf_events.

but if it's supposed to be providing info to user-space, shouldn't
it be *exported* to user space? it's not listed in include/linux/Kbuild. or am i misunderstanding?

No, you're quite correct, my guess would be that the original perf_counter.h header-y line was renamed to perf_event.h, and someone forgot to add a new one for the old header.

regards, Kyle

#4 lore raw
Quoted 5 lines · Kyle McMartin
Quoted 4 lines · Robert P. J. Day
Quoted 3 lines

See the comment at the top, it's being provided to provide the old names to userspace for a short time, now that the functionality has been renamed to perf_events.

Quoted 7 lines
Quoted 3 lines

but if it's supposed to be providing info to user-space,
shouldn't it be *exported* to user space? it's not listed in include/linux/Kbuild. or am i misunderstanding?

No, you're quite correct, my guess would be that the original perf_counter.h header-y line was renamed to perf_event.h, and someone forgot to add a new one for the old header.

so i can submit a patch to do one of two things:

1) add it into Kbuild, since user-space needs it, or

2) delete it entirely since it's never been in user-space all this time but no one seems to have missed it. :-)

thoughts? i'm fine either way.

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================

#5 lore raw
Quoted 6 lines · Robert P. J. Day

1) add it into Kbuild, since user-space needs it, or

2) delete it entirely since it's never been in user-space all this time but no one seems to have missed it. :-)

My guess is the latter, since it was never exported. I just noticed that Chuck added it to Kbuild after the rename, so it has never been exported at all with the previous interface.

#6 lore raw
Quoted 11 lines · Kyle McMartin
Quoted 6 lines · Robert P. J. Day

1) add it into Kbuild, since user-space needs it, or

2) delete it entirely since it's never been in user-space all this time but no one seems to have missed it. :-)

My guess is the latter, since it was never exported. I just noticed that Chuck added it to Kbuild after the rename, so it has never been exported at all with the previous interface.

sounds fair. deletion patch coming soon.

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================