Skip to contentSkip to conversation

which drivers subdirs should be automatically selected?

DISCUSSION Robert P. J. Day 3 participants 6 messages Dec 22, 2009 – Dec 23, 2009

lore
Share & tools
lore
#0 lore raw

drivers/Makefile:

obj-y   += net/
obj-y   += serial/
obj-y   += nand/
obj-y   += nor/
obj-y   += usb/

obj-$(CONFIG_SPI) += spi/
obj-$(CONFIG_I2C) += i2c/
obj-$(CONFIG_VIDEO) += video/

is there a fundamental reason that some of those subdirs are
auto-selected, while others are based on a CONFIG variable? asked another way, are there some driver subdirs that are so fundamentally required that they *should* be auto-selected, or should *everything* be a user-selectable choice? the above just seems slightly inconsistent and non-obvious.

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#1 lore raw
Quoted 12 lines · Robert P. J. Day

drivers/Makefile:

obj-y   += net/
obj-y   += serial/
obj-y   += nand/
obj-y   += nor/
obj-y   += usb/

obj-$(CONFIG_SPI) += spi/
obj-$(CONFIG_I2C) += i2c/
obj-$(CONFIG_VIDEO) += video/

Quoted 6 lines

is there a fundamental reason that some of those subdirs are
auto-selected, while others are based on a CONFIG variable? asked another way, are there some driver subdirs that are so fundamentally required that they *should* be auto-selected, or should *everything* be a user-selectable choice? the above just seems slightly inconsistent and non-obvious.

They should be selectable.

rsc

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#2 lore raw
Quoted 13 lines · Robert Schwebel
Quoted 12 lines · Robert P. J. Day

drivers/Makefile:

obj-y   += net/
obj-y   += serial/
obj-y   += nand/
obj-y   += nor/
obj-y   += usb/

obj-$(CONFIG_SPI) += spi/
obj-$(CONFIG_I2C) += i2c/
obj-$(CONFIG_VIDEO) += video/

Quoted 8 lines
Quoted 6 lines

is there a fundamental reason that some of those subdirs are
auto-selected, while others are based on a CONFIG variable? asked another way, are there some driver subdirs that are so fundamentally required that they *should* be auto-selected, or should *everything* be a user-selectable choice? the above just seems slightly inconsistent and non-obvious.

They should be selectable.

i thought as much. perhaps i'll start with that smaller fix and
work my way up if i can make that change in isolation to start with.

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#3 lore raw
In reply to Robert P. J. Day
Quoted 13 lines · Robert P. J. Day

drivers/Makefile:

obj-y   += net/
obj-y   += serial/
obj-y   += nand/
obj-y   += nor/
obj-y   += usb/

obj-$(CONFIG_SPI) += spi/
obj-$(CONFIG_I2C) += i2c/
obj-$(CONFIG_VIDEO) += video/

Quoted 6 lines

is there a fundamental reason that some of those subdirs are
auto-selected, while others are based on a CONFIG variable? asked another way, are there some driver subdirs that are so fundamentally required that they *should* be auto-selected, or should *everything* be a user-selectable choice? the above just seems slightly inconsistent and non-obvious.

Nothing of the above is really fundamental. Without serial drivers you won't see anything of course, but this won't stop barebox from working. I think this only reflects a change of taste during time and should be done consistently so that other people know how to do it. Prefered is the obj-$(CONFIG_SPI) += spi/ style.

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#4 lore raw
Quoted 5 lines · Sascha Hauer

Nothing of the above is really fundamental. Without serial drivers you won't see anything of course, but this won't stop barebox from working. I think this only reflects a change of taste during time and should be done consistently so that other people know how to do it. Prefered is the obj-$(CONFIG_SPI) += spi/ style.

It's also good in the "how small can we make it" game.

rsc

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#5 lore raw
In reply to Sascha Hauer
Quoted 21 lines · Sascha Hauer
Quoted 13 lines · Robert P. J. Day

drivers/Makefile:

obj-y   += net/
obj-y   += serial/
obj-y   += nand/
obj-y   += nor/
obj-y   += usb/

obj-$(CONFIG_SPI) += spi/
obj-$(CONFIG_I2C) += i2c/
obj-$(CONFIG_VIDEO) += video/

Quoted 6 lines

is there a fundamental reason that some of those subdirs are
auto-selected, while others are based on a CONFIG variable? asked another way, are there some driver subdirs that are so fundamentally required that they *should* be auto-selected, or should *everything* be a user-selectable choice? the above just seems slightly inconsistent and non-obvious.

Quoted 5 lines

Nothing of the above is really fundamental. Without serial drivers you won't see anything of course, but this won't stop barebox from working. I think this only reflects a change of taste during time and should be done consistently so that other people know how to do it. Prefered is the obj-$(CONFIG_SPI) += spi/ style.

fair enough, i can take a shot at that. stuff that's really basic
(like serial) can simply be marked as "default y" so you'd have to explicitly *exclude* it in unusual cases.

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox