Skip to contentSkip to conversation

HVSI: Fix apparently backwards args to time_before() in hvsi.c

PATCH In review Robert P. J. Day 3 participants 3 messages Jan 1, 2010 Char and misc drivers

lore
Share & tools
lore

Robert P. J. Day

author
#0 lore raw

PATCH 1/1 HVSI: Fix apparently backwards args to time_before() in hvsi.c

Signed-off-by Robert P. J. Day <[email protected]>

---

no appropriate subsystem maintainer listed in MAINTAINERS.

drivers/char/hvsi.c +1 -1
index 793b236..71c0fcd 100644
@@ -711,7 +711,7 @@ static void hvsi_drain_input(struct hvsi_struct *hp)
 	uint8_t buf[HVSI_MAX_READ] __ALIGNED__;
 	unsigned long end_jiffies = jiffies + HVSI_TIMEOUT;
 
-	while (time_before(end_jiffies, jiffies))
+	while (time_before(jiffies, end_jiffies))
 		if (0 == hvsi_read(hp, buf, HVSI_MAX_READ))
 			break;
 }

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================

#1 lore raw
Quoted 6 lines · Robert P. J. Day
Signed-off-by Robert P. J. Day <[email protected]>

---

no appropriate subsystem maintainer listed in MAINTAINERS.

drivers/char/Makefile:
obj-$(CONFIG_HVC_CONSOLE) += hvc_vio.o hvsi.o

so it should belong to:

HYPERVISOR VIRTUAL CONSOLE DRIVER

L:      [email protected]
S:      Odd Fixes
F:      drivers/char/hvc_*

[ Though maybe Ben would be willing to pick this one up directly
as hvsi is PPC specific thingy and patch is obviously correct. ]

drivers/char/hvsi.c static void hvsi_drain_input(struct hvsi_struct *hp) · line 717

Quoted 13 lines
drivers/char/hvsi.c +1 -1
index 793b236..71c0fcd 100644
@@ -711,7 +711,7 @@ static void hvsi_drain_input(struct hvsi_struct *hp)
 	uint8_t buf[HVSI_MAX_READ] __ALIGNED__;
 	unsigned long end_jiffies = jiffies + HVSI_TIMEOUT;
 
-	while (time_before(end_jiffies, jiffies))
+	while (time_before(jiffies, end_jiffies))
 		if (0 == hvsi_read(hp, buf, HVSI_MAX_READ))
 			break;
 }

--
Bartlomiej Zolnierkiewicz

#2 lore raw
Quoted 13 lines · Bartlomiej Zolnierkiewicz
Quoted 6 lines · Robert P. J. Day
Signed-off-by Robert P. J. Day <[email protected]>

---

no appropriate subsystem maintainer listed in MAINTAINERS.

drivers/char/Makefile:
obj-$(CONFIG_HVC_CONSOLE) += hvc_vio.o hvsi.o

so it should belong to:

Quoted 7 lines

HYPERVISOR VIRTUAL CONSOLE DRIVER

L:      [email protected]
S:      Odd Fixes
F:      drivers/char/hvc_*

[ Though maybe Ben would be willing to pick this one up directly
as hvsi is PPC specific thingy and patch is obviously correct. ]

Sure, I'll pick that one up.

Cheers,
Ben.

Quoted 21 lines

drivers/char/hvsi.c static void hvsi_drain_input(struct hvsi_struct *hp) · line 717

Quoted 13 lines
drivers/char/hvsi.c +1 -1
index 793b236..71c0fcd 100644
@@ -711,7 +711,7 @@ static void hvsi_drain_input(struct hvsi_struct *hp)
 	uint8_t buf[HVSI_MAX_READ] __ALIGNED__;
 	unsigned long end_jiffies = jiffies + HVSI_TIMEOUT;
 
-	while (time_before(end_jiffies, jiffies))
+	while (time_before(jiffies, end_jiffies))
 		if (0 == hvsi_read(hp, buf, HVSI_MAX_READ))
 			break;
 }

--
Bartlomiej Zolnierkiewicz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/