Skip to contentSkip to conversation

ACPICA: exfield: minor format change in error message (fwd)

PATCH In review Len Brown 2 participants 2 messages Feb 19, 2010

Subsystems (2)
lore
Share & tools
lore

Len Brown

author
#0 lore raw

PATCH 1/1 ACPICA: exfield: minor format change in error message (fwd)

Bob,
one for you.

thanks,
Len Brown, Intel Open Source Technology Center

---------- Forwarded message ----------
Date: Wed, 17 Feb 2010 03:13:27 +0000 (UTC)
From: Naga Chumbalkar <nagananda.chumbalkar(a)hp.com>
To: len.brown(a)intel.com
Cc: linux-acpi(a)vger.kernel.org, Naga Chumbalkar <nagananda.chumbalkar(a)hp.com>
Subject: [PATCH] ACPICA: exfield: minor format change in error message

Found this while debugging a problem. Trivial, but useful, format change.

Before:
ACPI Error: SMBus or IPMI write requires Buffer of length 42, found length 20 (20091214/exfield-285)

After:
ACPI Error: SMBus or IPMI write requires Buffer of length 66, found length 32 (20091214/exfield-286)

Signed-off-by Naga Chumbalkar <nagananda.chumbalkar(a)hp.com>
drivers/acpi/acpica/exfield.c +2 -1
index 1588a2d..be2b03a 100644
@@ -281,7 +281,8 @@ acpi_ex_write_data_to_field(union acpi_operand_object *source_desc,
 
 		if (source_desc->buffer.length < length) {
 			ACPI_ERROR((AE_INFO,
-				    "SMBus or IPMI write requires Buffer of length %X, found length %X",
+				    "SMBus or IPMI write requires Buffer of "
+				    "length %d, found length %d",
 				    length, source_desc->buffer.length));
 
 			return_ACPI_STATUS(AE_AML_BUFFER_LIMIT);

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#1 lore raw

Yes.

One nit:
+ "length %d, found length %d",

We usually use %u on these:

+ "length %u, found length %u",

Quoted 61 lines

-----Original Message-----
From: devel-bounces(a)acpica.org [mailto:devel-bounces(a)acpica.org] On Behalf Of Len Brown
Sent: Thursday, February 18, 2010 10:43 PM
To: devel(a)acpica.org
Cc: linux-acpi(a)vger.kernel.org; Naga Chumbalkar
Subject: [Devel] [PATCH] ACPICA: exfield: minor format change in error message (fwd)

Bob,
one for you.

thanks,
Len Brown, Intel Open Source Technology Center

---------- Forwarded message ----------
Date: Wed, 17 Feb 2010 03:13:27 +0000 (UTC)
From: Naga Chumbalkar <nagananda.chumbalkar(a)hp.com>
To: len.brown(a)intel.com
Cc: linux-acpi(a)vger.kernel.org, Naga Chumbalkar <nagananda.chumbalkar(a)hp.com>
Subject: [PATCH] ACPICA: exfield: minor format change in error message

Found this while debugging a problem. Trivial, but useful, format change.

Before:
ACPI Error: SMBus or IPMI write requires Buffer of length 42, found length 20
(20091214/exfield-285)

After:
ACPI Error: SMBus or IPMI write requires Buffer of length 66, found length 32
(20091214/exfield-286)

Signed-off-by Naga Chumbalkar <nagananda.chumbalkar(a)hp.com>
drivers/acpi/acpica/exfield.c +2 -1
index 1588a2d..be2b03a 100644
@@ -281,7 +281,8 @@ acpi_ex_write_data_to_field(union acpi_operand_object
 *source_desc,
 
 		if (source_desc->buffer.length < length) {
 			ACPI_ERROR((AE_INFO,
-				    "SMBus or IPMI write requires Buffer of length
 %X, found length %X",
+				    "SMBus or IPMI write requires Buffer of "
+				    "length %d, found length %d",
 				    length, source_desc->buffer.length));
			return_ACPI_STATUS(AE_AML_BUFFER_LIMIT);

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
Devel mailing list
Devel(a)acpica.org
http://lists.acpica.org/listinfo/devel