simplifying the linux MTD Kconfig/Makefile structure
it seems like the various Kconfigs and Makefiles related to MTD
could be tightened up a bit. for instance, in drivers/mtd/Makefile:
obj-$(CONFIG_MTD_UBI) += ubi/
but given that selection, it's kind of redundant to then have drivers/mtd/ubi/Makefile start with:
obj-$(CONFIG_MTD_UBI) += ubi.o
is it not? why not just "obj-y"?
along those lines, again from drivers/mtd/Makefile:
obj-y += chips/ lpddr/ maps/ devices/ nand/ onenand/ tests/
obj-$(CONFIG_MTD_UBI) += ubi/
why not be consistent and have:
obj-y += chips/ lpddr/ maps/ devices/ nand/ onenand/
obj-$(CONFIG_MTD_UBI) += ubi/
obj-$(CONFIG_MTD_TESTS) += tests/
which would *massively* simplify drivers/mtd/tests/Makefile, would it not?
i can submit some patches if there's any interest. i suspect some
of the other directories could be similarly tidied up.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday
========================================================================
Quoted 22 lines · Robert P. J. Day
it seems like the various Kconfigs and Makefiles related to MTD could be tightened up a bit. for instance, in
drivers/mtd/Makefile:obj-$(CONFIG_MTD_UBI) += ubi/but given that selection, it's kind of redundant to then have
drivers/mtd/ubi/Makefilestart with:obj-$(CONFIG_MTD_UBI) += ubi.ois it not? why not just "obj-y"?
along those lines, again from
drivers/mtd/Makefile:obj-y += chips/ lpddr/ maps/ devices/ nand/ onenand/ tests/
obj-$(CONFIG_MTD_UBI) += ubi/
why not be consistent and have:
obj-y += chips/ lpddr/ maps/ devices/ nand/ onenand/
Quoted 8 lines
obj-$(CONFIG_MTD_UBI) += ubi/
obj-$(CONFIG_MTD_TESTS) += tests/which would *massively* simplify
drivers/mtd/tests/Makefile, would it not?i can submit some patches if there's any interest. i suspect some
of the other directories could be similarly tidied up.
Sounds like a reasonable clean-up to me.
Signature · 2 lines
Best Regards, Artem Bityutskiy (Артём Битюцкий)
Quoted 26 lines · Artem Bityutskiy
Quoted 25 lines · Robert P. J. Day
it seems like the various Kconfigs and Makefiles related to MTD could be tightened up a bit. for instance, in
drivers/mtd/Makefile:obj-$(CONFIG_MTD_UBI) += ubi/but given that selection, it's kind of redundant to then have
drivers/mtd/ubi/Makefilestart with:obj-$(CONFIG_MTD_UBI) += ubi.ois it not? why not just "obj-y"?
along those lines, again from
drivers/mtd/Makefile:obj-y += chips/ lpddr/ maps/ devices/ nand/ onenand/ tests/
obj-$(CONFIG_MTD_UBI) += ubi/
why not be consistent and have:
obj-y += chips/ lpddr/ maps/ devices/ nand/ onenand/
obj-$(CONFIG_MTD_UBI) += ubi/
obj-$(CONFIG_MTD_TESTS) += tests/
Quoted 7 lines
Quoted 5 lines
which would *massively* simplify
drivers/mtd/tests/Makefile, would it not?i can submit some patches if there's any interest. i suspect some
of the other directories could be similarly tidied up.Sounds like a reasonable clean-up to me.
sorry for the delay, either i or a local buddy will take care of
this and submit patches to the list.
rday
Signature · 8 lines
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================