Skip to contentSkip to conversation

MM: Make "struct vm_region {...}" depend on !CONFIG_MMU.

PATCH New Robert P. J. Day 1 participant 1 message Apr 5, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MM: Make "struct vm_region {...}" depend on !CONFIG_MMU.

Since the "vm_region" structure appears to be relevant only under NOMMU, conditionally include it in mm_types.h.

---

if i read mm_types.h, i can see the obvious conditional inclusion:

#ifndef CONFIG_MMU
struct vm_region *vm_region; /* NOMMU mapping region */
#endif

since that's the case, it seems only consistent to make the structure declaration itself similarly conditional, no?

include/linux/mm_types.h +2 -0
index b8bb9a6..76f1174 100644
@@ -102,6 +102,7 @@ struct page {
 #endif
 };
 
+#ifndef CONFIG_MMU
 /*
  * A region containing a mapping of a non-memory backed file under NOMMU
  * conditions.  These are held in a global tree and are pinned by the VMAs that
@@ -120,6 +121,7 @@ struct vm_region {
 	bool		vm_icache_flushed : 1; /* true if the icache has been flushed for
 						* this region */
 };
+#endif
 
 /*
  * This struct defines a memory VMM memory area. There is one of these

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>