125 run ftrunc with relative path
PATCH 1/1 125 run ftrunc with relative path
Quoted 1 line
From
16588d733e681954386f1b92dd6e47cfef92a207Mon Sep 17 00:00:00 2001
From: Lukas Czerner <[email protected]>
Date: Tue, 13 Apr 2010 19:34:07 +0200
Subject: [PATCH] 125 run ftrunc with relative path
Since ftrunc is invoked with su $qa_user, it can fail when absolute path is not accessible to everyone.
--- 125 | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
125 +1 -1
@@ -61,7 +61,7 @@ touch $TESTFILE chmod a+rw $TESTDIR chmod a+rw $TESTFILE -su $qa_user -c "$here/src/ftrunc -f $TESTFILE" +su $qa_user -c "./src/ftrunc -f $TESTFILE" if [ "$?" != "0" ]; then echo src/ftrunc returned non 0 status!
Signature · 6 lines
1.6.6.1 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 7 lines · Lukas Czerner
From
16588d733e681954386f1b92dd6e47cfef92a207Mon Sep 17 00:00:00 2001
From: Lukas Czerner <[email protected]>
Date: Tue, 13 Apr 2010 19:34:07 +0200
Subject: [PATCH] 125 run ftrunc with relative pathSince ftrunc is invoked with su $qa_user, it can fail when absolute path is not accessible to everyone.
Looks right to me.
After talking w/ you on IRC, I'll take the liberty of adding your
signed-off-by: to the patch, and check it in with my reviewed-by:
Thanks,
-Eric
Quoted 9 lines
--- 125 | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)125 +0
-0
125 touch $TESTFILE · line 67
Quoted 8 lines
125 +1
-1@@ -61,7 +61,7 @@ touch $TESTFILE chmod a+rw $TESTDIR chmod a+rw $TESTFILE -su $qa_user -c "$here/src/ftrunc -f $TESTFILE" +su $qa_user -c "./src/ftrunc -f $TESTFILE" if [ "$?" != "0" ]; then echo src/ftrunc returned non 0 status!
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs