inconsistent ways of setting IMAGE_FSTYPES
not a big deal, but just noticed the various formats for assigningIMAGE_FSTYPES in the meta-yocto layer:
$ grep -r IMAGE_FSTYPES *
meta-yocto/conf/distro/poky-tiny.conf:IMAGE_FSTYPES = "ext2 cpio.gz"
meta-yocto-bsp/conf/machine/edgerouter.conf:IMAGE_FSTYPES ?= "jffs2 tar.bz2"
meta-yocto-bsp/conf/machine/beaglebone.conf:IMAGE_FSTYPES += "tar.bz2 jffs2"
meta-yocto-bsp/conf/machine/mpc8315e-rdb.conf:IMAGE_FSTYPES ?= "jffs2 tar.bz2"
scripts/lib/bsp/substrate/target/arch/arm/conf/machine/{{=machine}}.conf:IMAGE_FSTYPES += "tar.bz2 jffs2"
scripts/lib/bsp/substrate/target/arch/mips/conf/machine/{{=machine}}.conf:IMAGE_FSTYPES ?= "jffs2 tar.bz2"
$ just seems a bit odd for those assignments to be bouncing around
between =, += and ?=.
rday
Signature · 7 lines
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================Quoted 14 lines · On Sunday 13 July 2014 13:44:53 Robert P. J. Day wrote:
not a big deal, but just noticed the various formats for assigning
IMAGE_FSTYPESin the meta-yocto layer:$ grep -r IMAGE_FSTYPES * meta-yocto/conf/distro/poky-tiny.conf:IMAGE_FSTYPES = "ext2 cpio.gz" meta-yocto-bsp/conf/machine/edgerouter.conf:IMAGE_FSTYPES ?= "jffs2 tar.bz2" meta-yocto-bsp/conf/machine/beaglebone.conf:IMAGE_FSTYPES += "tar.bz2 jffs2" meta-yocto-bsp/conf/machine/mpc8315e-rdb.conf:IMAGE_FSTYPES ?= "jffs2 tar.bz2" scripts/lib/bsp/substrate/target/arch/arm/conf/machine/{{=machine}}.conf:IM AGE_FSTYPES += "tar.bz2 jffs2" scripts/lib/bsp/substrate/target/arch/mips/conf/machine/{{=machine}}.conf:I MAGE_FSTYPES ?= "jffs2 tar.bz2" $
Quoted 2 lines
just seems a bit odd for those assignments to be bouncing around
between =, += and ?=.
I have to admit I thought we had established quite a long time ago in OE history that += was the correct way to set IMAGE_FSTYPES from a machine config file, although a quick search didn't turn up the thread where we discussed it. We're apparently not consistent with that at the moment however.
Cheers,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre
Quoted 15 lines · Paul Eggleton
Quoted 14 lines · On Sunday 13 July 2014 13:44:53 Robert P. J. Day wrote:
not a big deal, but just noticed the various formats for assigning
IMAGE_FSTYPESin the meta-yocto layer:$ grep -r IMAGE_FSTYPES * meta-yocto/conf/distro/poky-tiny.conf:IMAGE_FSTYPES = "ext2 cpio.gz" meta-yocto-bsp/conf/machine/edgerouter.conf:IMAGE_FSTYPES ?= "jffs2 tar.bz2" meta-yocto-bsp/conf/machine/beaglebone.conf:IMAGE_FSTYPES += "tar.bz2 jffs2" meta-yocto-bsp/conf/machine/mpc8315e-rdb.conf:IMAGE_FSTYPES ?= "jffs2 tar.bz2" scripts/lib/bsp/substrate/target/arch/arm/conf/machine/{{=machine}}.conf:IM AGE_FSTYPES += "tar.bz2 jffs2" scripts/lib/bsp/substrate/target/arch/mips/conf/machine/{{=machine}}.conf:I MAGE_FSTYPES ?= "jffs2 tar.bz2" $
Quoted 8 lines
Quoted 2 lines
just seems a bit odd for those assignments to be bouncing around
between =, += and ?=.I have to admit I thought we had established quite a long time ago in OE history that += was the correct way to set
IMAGE_FSTYPESfrom a machine config file, although a quick search didn't turn up the thread where we discussed it. We're apparently not consistent with that at the moment however.
i will leave this to someone higher up the evolutionary ladder since
i suspect it's not just a blind, across-the-board textual substitution. for example, poky-tiny.conf specifically claims:
# By default we only support ext2 and initramfs. We don't build live as that
# pulls in a lot of dependencies for the live image and the installer, like # udev, grub, etc. These pull in gettext, which fails to build with wide # character support. IMAGE_FSTYPES = "ext2 cpio.gz"
so someone else can have at this.
rday
Signature · 7 lines
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================