Skip to contentSkip to conversation

should layers define BB_DANGLINGAPPENDS_WARNONLY ?= "1"?

DISCUSSION Robert P. J. Day 4 participants 5 messages Nov 2, 2015 – Nov 3, 2015

lore
Share & tools
lore
#0 lore raw

perusing the meta-musl layer, and noticed in layer.conf the line:

BB_DANGLINGAPPENDS_WARNONLY ?= "1"

i thought this was a bit odd since (at least to me) it seems like the sort of thing a *developer* might set in their local.conf to temporarily deal with a dangling .bbappend file -- it never occurred to me that it would be appropriate for a layer to define that value itself as an inherent part of its own ... layerness.

a quick grep of the couple dozen layers i have checked out revealed
two layers that do that:

./meta-musl/conf/layer.conf:BB_DANGLINGAPPENDS_WARNONLY ?= "1" ./meta-yocto-kernel-extras/meta-kernel-dev/conf/layer.conf:BB_DANGLINGAPPENDS_WARNONLY ?= "true"

i'm curious what others think of this approach.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#1 lore raw

Hi Robert,

Quoted 10 lines · On Monday 02 November 2015 12:54:33 Robert P. J. Day wrote:

perusing the meta-musl layer, and noticed in layer.conf the line:

BB_DANGLINGAPPENDS_WARNONLY ?= "1"

i thought this was a bit odd since (at least to me) it seems like the sort of thing a *developer* might set in their local.conf to temporarily deal with a dangling .bbappend file -- it never occurred to me that it would be appropriate for a layer to define that value itself as an inherent part of its own ... layerness.

Quoted 8 lines

a quick grep of the couple dozen layers i have checked out revealed
two layers that do that:

./meta-musl/conf/layer.conf:BB_DANGLINGAPPENDS_WARNONLY ?= "1" ./meta-yocto-kernel-extras/meta-kernel-dev/conf/layer.conf:BB_DANGLINGAPPEND S_WARNONLY ?= "true"

i'm curious what others think of this approach.

I'd say no, they shouldn't really. As a user of the layer you might not realise that it's making this change to your configuration.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#2 lore raw
In reply to Robert P. J. Day
Quoted 11 lines · Robert P. J. Day

perusing the meta-musl layer, and noticed in layer.conf the line:

BB_DANGLINGAPPENDS_WARNONLY ?= "1"

i thought this was a bit odd since (at least to me) it seems like the sort of thing a *developer* might set in their local.conf to temporarily deal with a dangling .bbappend file -- it never occurred to me that it would be appropriate for a layer to define that value itself as an inherent part of its own ... layerness.

Quoted 8 lines

a quick grep of the couple dozen layers i have checked out revealed
two layers that do that:

./meta-musl/conf/layer.conf:BB_DANGLINGAPPENDS_WARNONLY ?= "1" ./meta-yocto-kernel-extras/meta-kernel-dev/conf/layer.conf:BB_DANGLINGAPPENDS_WARNONLY ?= "true"

i'm curious what others think of this approach.

Sounds dangerous, bordering on incorrect (or irresponsible) to me. This could easily mask a problem and is not layer specific, i.e. the warning would then apply to all layers, not just meta-musl.

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
#3 lore raw
In reply to Robert P. J. Day
Quoted 4 lines · Robert P. J. Day

perusing the meta-musl layer, and noticed in layer.conf the line:

BB_DANGLINGAPPENDS_WARNONLY ?= "1"

should be avoided although meta-musl is a bit core in nature. this is so that it can interface with several different compilers coming from different layers and also different oe-core releases can work with same branch of meta-musl.
one may not have same layers attached to it. Ideally, those patches
should now become part
of the original layers as they have been accepted in gcc upstream and so on. Hopefully as I will take
this into oe-core in coming months this should disappear.

Quoted 33 lines

i thought this was a bit odd since (at least to me) it seems like the sort of thing a *developer* might set in their local.conf to temporarily deal with a dangling .bbappend file -- it never occurred to me that it would be appropriate for a layer to define that value itself as an inherent part of its own ... layerness.

a quick grep of the couple dozen layers i have checked out revealed
two layers that do that:

./meta-musl/conf/layer.conf:BB_DANGLINGAPPENDS_WARNONLY ?= "1" ./meta-yocto-kernel-extras/meta-kernel-dev/conf/layer.conf:BB_DANGLINGAPPENDS_WARNONLY ?= "true"

i'm curious what others think of this approach.

rday

--

========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday

========================================================================

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

#4 lore raw
Quoted 6 lines · Khem Raj
Quoted 4 lines · Robert P. J. Day

perusing the meta-musl layer, and noticed in layer.conf the line:

BB_DANGLINGAPPENDS_WARNONLY ?= "1"

Quoted 9 lines

should be avoided although meta-musl is a bit core in nature. this is so that it can interface with several different compilers coming from different layers and also different oe-core releases can work with same branch of meta-musl.
one may not have same layers attached to it. Ideally, those patches
should now become part
of the original layers as they have been accepted in gcc upstream and so on. Hopefully as I will take
this into oe-core in coming months this should disappear.

ok, that's fair ... i didn't consider this a major issue, i just
thought it was a bit odd.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================