Skip to contentSkip to conversation

meta-oe: Standardize use of "_append" versus use of "+="

PATCH New Robert P. J. Day 1 participant 1 message Aug 18, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 meta-oe: Standardize use of "_append" versus use of "+="

Remove superfluous "+=", then manually add necessary leading space.

---

not build-tested, but looks pretty straightforward.

meta-oe/recipes-connectivity/krb5/krb5_1.13.2.bb +2 -2
index 500e194..3a3886b 100644
@@ -57,8 +57,8 @@ CACHED_CONFIGUREVARS += "krb5_cv_attr_constructor_destructor=yes ac_cv_func_regc
                   ac_cv_printf_positional=yes ac_cv_file__etc_environment=yes \
                   ac_cv_file__etc_TIMEZONE=no"
 
-CFLAGS_append += "-DDESTRUCTOR_ATTR_WORKS=1 -I${STAGING_INCDIR}/et"
-LDFLAGS_append += "-lpthread"
+CFLAGS_append = " -DDESTRUCTOR_ATTR_WORKS=1 -I${STAGING_INCDIR}/et"
+LDFLAGS_append = " -lpthread"
 
 FILES_${PN} += "${datadir}/gnats"
 FILES_${PN}-doc += "${datadir}/examples"
meta-oe/recipes-connectivity/zabbix/zabbix_2.4.7.bb +1 -1
index c2c4eae..03bad31 100644
@@ -53,7 +53,7 @@ EXTRA_OECONF = '--enable-dependency-tracking \
 	        --with-ssh2 \
 	        --with-sqlite3 \
 	        '
-CFLAGS_append += "-lldap -llber"
+CFLAGS_append = " -lldap -llber"
 
 do_configure_prepend() {
     export KERNEL_VERSION="${KERNEL_VERSION}"
meta-oe/recipes-connectivity/zeromq/zeromq_4.1.5.bb +2 -2
index 3fa5724..34749d0 100644
@@ -16,8 +16,8 @@ S = "${WORKDIR}/zeromq-${PV}"
 
 #Uncomment to choose polling system manually. valid values are kqueue, epoll, devpoll, poll or select
 #EXTRA_OECONF += "--with-poller=kqueue"
-#CFLAGS_append += "-O0"
-#CXXFLAGS_append += "-O0"
+#CFLAGS_append = " -O0"
+#CXXFLAGS_append = " -O0"
 
 inherit autotools ptest pkgconfig
 
Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================