Skip to contentSkip to conversation

"best practice" for including common header file content?

U-Boot Robert P. J. Day 2 participants 2 messages Apr 9, 2019 – Apr 10, 2019

lore
Share & tools
lore
#0 lore raw

more excruciatingly pedantic queries ... what is the best practice
for header files under include/configs including common header files also in that same directory. i give you:

$ git grep zynq-common.h
bitmain_antminer_s9.h:#include <configs/zynq-common.h>
syzygy_hub.h: * See zynq-common.h for Zynq common configs
syzygy_hub.h:#include <configs/zynq-common.h>
topic_miami.h: * See zynq-common.h for Zynq common configs
topic_miami.h:#include "zynq-common.h"
zynq_cse.h: * See zynq-common.h for Zynq common configs
zynq_cse.h:#include <configs/zynq-common.h>
$

so some of them include "zynq-common.h", while others include
<configs/zynq-common.h>. naturally, both work -- does u-boot have a stylistic preference?

rday

#1 lore raw

Hi,

Quoted 15 lines · Robert P. J. Day

more excruciatingly pedantic queries ... what is the best practice
for header files under include/configs including common header files also in that same directory. i give you:

$ git grep zynq-common.h
bitmain_antminer_s9.h:#include <configs/zynq-common.h>
syzygy_hub.h: * See zynq-common.h for Zynq common configs
syzygy_hub.h:#include <configs/zynq-common.h>
topic_miami.h: * See zynq-common.h for Zynq common configs
topic_miami.h:#include "zynq-common.h"
zynq_cse.h: * See zynq-common.h for Zynq common configs
zynq_cse.h:#include <configs/zynq-common.h>
$
Quoted 3 lines

so some of them include "zynq-common.h", while others include
<configs/zynq-common.h>. naturally, both work -- does u-boot have a stylistic preference?

I am not aware about any stylistic preference written anywhere.

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190410/d3c4afa3/attachment.sig>