Skip to contentSkip to conversation

drivers/usb/host/Kconfig: Drop CONFIG_ prefix from select

PATCH New Robert P. J. Day 2 participants 6 messages Apr 14, 2019 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/usb/host/Kconfig: Drop CONFIG_ prefix from select

Kbuild "select" directives should not include "CONFIG_" prefix.

---

drivers/usb/host/Kconfig +1 -1
index ba1e6bfa43..96474f4e3b 100644
@@ -204,7 +204,7 @@ config USB_EHCI_GENERIC
 config USB_EHCI_FSL
 	bool  "Support for FSL on-chip EHCI USB controller"
 	default n
-	select  CONFIG_EHCI_HCD_INIT_AFTER_RESET
+	select EHCI_HCD_INIT_AFTER_RESET
 	---help---
 	  Enables support for the on-chip EHCI controller on FSL chips.
 endif # USB_EHCI_HCD
Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                         http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#1 lore raw

PATCH 1/1 drivers/usb/host/Kconfig: Drop CONFIG_ prefix from select

Quoted 4 lines · Robert P. J. Day

Kbuild "select" directives should not include "CONFIG_" prefix.

The patch is correct, but does it have any side-effects ?

Quoted 16 lines

---

drivers/usb/host/Kconfig +1 -1
index ba1e6bfa43..96474f4e3b 100644
@@ -204,7 +204,7 @@ config USB_EHCI_GENERIC
 config USB_EHCI_FSL
 	bool  "Support for FSL on-chip EHCI USB controller"
 	default n
-	select  CONFIG_EHCI_HCD_INIT_AFTER_RESET
+	select EHCI_HCD_INIT_AFTER_RESET
 	---help---
 	  Enables support for the on-chip EHCI controller on FSL chips.
 endif # USB_EHCI_HCD
Signature · 2 lines
Best regards,
Marek Vasut
#2 lore raw

PATCH 1/1 drivers/usb/host/Kconfig: Drop CONFIG_ prefix from select

Quoted 10 lines · Marek Vasut
Quoted 4 lines · Robert P. J. Day

Kbuild "select" directives should not include "CONFIG_" prefix.

The patch is correct, but does it have any side-effects ?

Quoted 2 lines

---

Quoted 14 lines
Quoted 6 lines
drivers/usb/host/Kconfig +0 -0
index ba1e6bfa43..96474f4e3b 100644

drivers/usb/host/Kconfig config USB_EHCI_GENERIC · line 210

Quoted 8 lines
drivers/usb/host/Kconfig +1 -1
@@ -204,7 +204,7 @@ config USB_EHCI_GENERIC
 config USB_EHCI_FSL
 	bool  "Support for FSL on-chip EHCI USB controller"
 	default n
-	select  CONFIG_EHCI_HCD_INIT_AFTER_RESET
+	select EHCI_HCD_INIT_AFTER_RESET
 	---help---
 	  Enables support for the on-chip EHCI controller on FSL chips.
 endif # USB_EHCI_HCD

there are a *ton* of include/configs/ header files that
already contain:

  #define CONFIG_EHCI_HCD_INIT_AFTER_RESET

and the only test i can see for it is in drivers/usb/host/ehci-hcd.c:

  #if defined(CONFIG_EHCI_HCD_INIT_AFTER_RESET)
        rc = ehci_hcd_init(index, init, &ctrl->hccr, &ctrl->hcor);
        if (rc)
                return rc;
  #endif

so i would *think* that, given the number of boards that already explicitly include that feature, it's unlikely that fixing that Kconfig file would suddenly reveal an issue that was hidden until now. but that's just a guess.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                         http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#3 lore raw

PATCH 1/1 drivers/usb/host/Kconfig: Drop CONFIG_ prefix from select

Quoted 30 lines · Robert P. J. Day
Quoted 10 lines · Marek Vasut
Quoted 4 lines · Robert P. J. Day

Kbuild "select" directives should not include "CONFIG_" prefix.

The patch is correct, but does it have any side-effects ?

Quoted 2 lines

---

Quoted 14 lines
Quoted 6 lines
drivers/usb/host/Kconfig +0 -0
index ba1e6bfa43..96474f4e3b 100644

drivers/usb/host/Kconfig config USB_EHCI_GENERIC · line 210

Quoted 8 lines
drivers/usb/host/Kconfig +1 -1
@@ -204,7 +204,7 @@ config USB_EHCI_GENERIC
 config USB_EHCI_FSL
 	bool  "Support for FSL on-chip EHCI USB controller"
 	default n
-	select  CONFIG_EHCI_HCD_INIT_AFTER_RESET
+	select EHCI_HCD_INIT_AFTER_RESET
 	---help---
 	  Enables support for the on-chip EHCI controller on FSL chips.
 endif # USB_EHCI_HCD

there are a *ton* of include/configs/ header files that
already contain:

Quoted 1 line
  #define CONFIG_EHCI_HCD_INIT_AFTER_RESET

And those boards also enable USB_EHCI_FSL ? If so, then it might also make sense to remove these #define CONFIG_EHCI_HCD_INIT_AFTER_RESET from the header files.

I think ./tools/moveconfig.py could help you with that cleanup .

Quoted 15 lines

and the only test i can see for it is in drivers/usb/host/ehci-hcd.c:

  #if defined(CONFIG_EHCI_HCD_INIT_AFTER_RESET)
        rc = ehci_hcd_init(index, init, &ctrl->hccr, &ctrl->hcor);
        if (rc)
                return rc;
  #endif

so i would *think* that, given the number of boards that already explicitly include that feature, it's unlikely that fixing that Kconfig file would suddenly reveal an issue that was hidden until now. but that's just a guess.

rday

Signature · 2 lines
Best regards,
Marek Vasut
#4 lore raw

PATCH 1/1 drivers/usb/host/Kconfig: Drop CONFIG_ prefix from select

Quoted 31 lines · Marek Vasut
Quoted 30 lines · Robert P. J. Day
Quoted 10 lines · Marek Vasut
Quoted 4 lines · Robert P. J. Day

Kbuild "select" directives should not include "CONFIG_" prefix.

The patch is correct, but does it have any side-effects ?

Quoted 2 lines

---

Quoted 14 lines
Quoted 6 lines
drivers/usb/host/Kconfig +0 -0
index ba1e6bfa43..96474f4e3b 100644

drivers/usb/host/Kconfig config USB_EHCI_GENERIC · line 210

Quoted 8 lines
drivers/usb/host/Kconfig +1 -1
@@ -204,7 +204,7 @@ config USB_EHCI_GENERIC
 config USB_EHCI_FSL
 	bool  "Support for FSL on-chip EHCI USB controller"
 	default n
-	select  CONFIG_EHCI_HCD_INIT_AFTER_RESET
+	select EHCI_HCD_INIT_AFTER_RESET
 	---help---
 	  Enables support for the on-chip EHCI controller on FSL chips.
 endif # USB_EHCI_HCD

there are a *ton* of include/configs/ header files that
already contain:

Quoted 7 lines
Quoted 1 line
  #define CONFIG_EHCI_HCD_INIT_AFTER_RESET

And those boards also enable USB_EHCI_FSL ? If so, then it might also make sense to remove these #define CONFIG_EHCI_HCD_INIT_AFTER_RESET from the header files.

I think ./tools/moveconfig.py could help you with that cleanup .

ok, i'll take a closer look first chance i get. clearly, there's
potentially more cleanup here than just fixing a typo.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                         http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#5 lore raw

PATCH 1/1 drivers/usb/host/Kconfig: Drop CONFIG_ prefix from select

Quoted 35 lines · Robert P. J. Day
Quoted 33 lines · Marek Vasut
Quoted 31 lines · Robert P. J. Day
Quoted 10 lines · Marek Vasut
Quoted 4 lines · Robert P. J. Day

Kbuild "select" directives should not include "CONFIG_" prefix.

The patch is correct, but does it have any side-effects ?

Quoted 2 lines

---

Quoted 14 lines
Quoted 6 lines
drivers/usb/host/Kconfig +0 -0
index ba1e6bfa43..96474f4e3b 100644

drivers/usb/host/Kconfig config USB_EHCI_GENERIC · line 210

Quoted 8 lines
drivers/usb/host/Kconfig +1 -1
@@ -204,7 +204,7 @@ config USB_EHCI_GENERIC
 config USB_EHCI_FSL
 	bool  "Support for FSL on-chip EHCI USB controller"
 	default n
-	select  CONFIG_EHCI_HCD_INIT_AFTER_RESET
+	select EHCI_HCD_INIT_AFTER_RESET
 	---help---
 	  Enables support for the on-chip EHCI controller on FSL chips.
 endif # USB_EHCI_HCD

there are a *ton* of include/configs/ header files that
already contain:

  #define CONFIG_EHCI_HCD_INIT_AFTER_RESET
Quoted 8 lines
Quoted 5 lines

And those boards also enable USB_EHCI_FSL ? If so, then it might also make sense to remove these #define CONFIG_EHCI_HCD_INIT_AFTER_RESET from the header files.

I think ./tools/moveconfig.py could help you with that cleanup .

ok, i'll take a closer look first chance i get. clearly, there's
potentially more cleanup here than just fixing a typo.

Thanks!

Signature · 2 lines
Best regards,
Marek Vasut