bin_package.bbclass: emphasize setting of S with "subdir"
PATCH 1/1 bin_package.bbclass: emphasize setting of S with "subdir"
Clarify the setting of "S" so there is absolutely no confusion.
---
meta/classes/bin_package.bbclass +2 -2
@@ -14,8 +14,8 @@ # # SRC_URI = "http://foo.com/foo-1.0-r1.i586.rpm;subdir=foo-1.0" # -# Then the files would be unpacked to ${WORKDIR}/foo-1.0, otherwise -# they would be in ${WORKDIR}. +# Then the files would be unpacked to S=${WORKDIR}/foo-1.0, otherwise +# they would be in S=${WORKDIR}. # # Skip the unwanted steps
Signature · 7 lines
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================Quoted 11 lines · On Sat, 2020-04-04 at 08:00 -0400, [email protected] wrote:
Clarify the setting of "S" so there is absolutely no confusion.
Signed-off-by Robert P. J. Day <[email protected]>---
meta/classes/bin_package.bbclass +0
-0
meta/classes/bin_package.bbclass line 19
Quoted 8 lines
meta/classes/bin_package.bbclass +2
-2@@ -14,8 +14,8 @@ # # SRC_URI = "http://foo.com/foo-1.0-r1.i586.rpm;subdir=foo-1.0" # -# Then the files would be unpacked to ${WORKDIR}/foo-1.0, otherwise -# they would be in ${WORKDIR}. +# Then the files would be unpacked to S=${WORKDIR}/foo-1.0, otherwise +# they would be in S=${WORKDIR}. #
I strongly disagree actually. Setting subdir in SRC_URI does not change the value of S. What happens is what the comment says, its unpacked to ${WORKDIR}/foo-1.0, or ${WORKDIR}. The value of S remains at whatever its set to.
Cheers,
Richard
Quoted 17 lines · Richard Purdie
Quoted 16 lines · On Sat, 2020-04-04 at 08:00 -0400, [email protected] wrote:
Clarify the setting of "S" so there is absolutely no confusion.
Signed-off-by Robert P. J. Day <[email protected]>---
meta/classes/bin_package.bbclass +0
-2@@ -14,8 +14,8 @@ # # SRC_URI = "http://foo.com/foo-1.0-r1.i586.rpm;subdir=foo-1.0" # -# Then the files would be unpacked to ${WORKDIR}/foo-1.0, otherwise -# they would be in ${WORKDIR}.
Quoted 8 lines
meta/classes/bin_package.bbclass line 19
Quoted 3 lines
meta/classes/bin_package.bbclass +2
-0+# Then the files would be unpacked to S=${WORKDIR}/foo-1.0, otherwise +# they would be in S=${WORKDIR}. #I strongly disagree actually. Setting subdir in
SRC_URIdoes not change the value of S. What happens is what the comment says, its unpacked to ${WORKDIR}/foo-1.0, or ${WORKDIR}. The value of S remains at whatever its set to.
oh, i didn't realize that, my mistake. i could have sworn ...
rday
Quoted 17 lines · Richard Purdie
Quoted 16 lines · On Sat, 2020-04-04 at 08:00 -0400, [email protected] wrote:
Clarify the setting of "S" so there is absolutely no confusion.
Signed-off-by Robert P. J. Day <[email protected]>---
meta/classes/bin_package.bbclass +0
-2@@ -14,8 +14,8 @@ # # SRC_URI = "http://foo.com/foo-1.0-r1.i586.rpm;subdir=foo-1.0" # -# Then the files would be unpacked to ${WORKDIR}/foo-1.0, otherwise -# they would be in ${WORKDIR}.
Quoted 8 lines
meta/classes/bin_package.bbclass line 19
Quoted 3 lines
meta/classes/bin_package.bbclass +2
-0+# Then the files would be unpacked to S=${WORKDIR}/foo-1.0, otherwise +# they would be in S=${WORKDIR}. #I strongly disagree actually. Setting subdir in
SRC_URIdoes not change the value of S. What happens is what the comment says, its unpacked to ${WORKDIR}/foo-1.0, or ${WORKDIR}. The value of S remains at whatever its set to.
so if one inherits bin_package and uses a "subdir" option, what is
installed (via tar) is the entire subdir directory structure, as in
foo-1.0/*
unless the recipe explicitly sets S to match it, is that it? that might be worth noting in the comments, then.
rday
Quoted 34 lines · Robert P. J. Day
Quoted 24 lines · Richard Purdie
Quoted 19 lines · On Sat, 2020-04-04 at 08:00 -0400, [email protected] wrote:
Clarify the setting of "S" so there is absolutely no confusion.
Signed-off-by Robert P. J. Day <[email protected]>---
meta/classes/bin_package.bbclass +0
-1@@ -14,8 +14,8 @@ # # SRC_URI = "http://foo.com/foo-1.0-r1.i586.rpm;subdir=foo-1.0" # -# Then the files would be unpacked to ${WORKDIR}/foo-1.0,otherwise
meta/classes/bin_package.bbclass +1
-1-# they would be in ${WORKDIR}. +# Then the files would be unpacked to S=${WORKDIR}/foo-1.0,Quoted 3 lines
otherwise
+# they would be in S=${WORKDIR}.
#Quoted 7 lines
I strongly disagree actually. Setting subdir in
SRC_URIdoes not change
the value of S. What happens is what the comment says, its unpacked to
${WORKDIR}/foo-1.0, or ${WORKDIR}. The value of S remains at whatever
its set to.
Quoted 4 lines
so if one inherits
bin_packageand uses a "subdir" option, what is
installed (via tar) is the entire subdir directory structure, as infoo-1.0/*
That sounds more confusing.
The source component of SRC_URI that has subdir set against it is extracted to ${WORKDIR}/<subdir> rather than ${WORKDIR}/. Nothing more, nothing less.
Quoted 2 lines
unless the recipe explicitly sets S to match it, is that it? that might be worth noting in the comments, then.
S has nothing to do with this so stop trying to include it.
Cheers,
Richard
Quoted 42 lines · Richard Purdie
Quoted 34 lines · Robert P. J. Day
Quoted 24 lines · Richard Purdie
Quoted 19 lines · On Sat, 2020-04-04 at 08:00 -0400, [email protected] wrote:
Clarify the setting of "S" so there is absolutely no confusion.
Signed-off-by Robert P. J. Day <[email protected]>---
meta/classes/bin_package.bbclass +0
-1@@ -14,8 +14,8 @@ # # SRC_URI = "http://foo.com/foo-1.0-r1.i586.rpm;subdir=foo-1.0" # -# Then the files would be unpacked to ${WORKDIR}/foo-1.0,otherwise
meta/classes/bin_package.bbclass +1
-1-# they would be in ${WORKDIR}. +# Then the files would be unpacked to S=${WORKDIR}/foo-1.0,Quoted 3 lines
otherwise
+# they would be in S=${WORKDIR}.
#Quoted 7 lines
I strongly disagree actually. Setting subdir in
SRC_URIdoes not change
the value of S. What happens is what the comment says, its unpacked to
${WORKDIR}/foo-1.0, or ${WORKDIR}. The value of S remains at whatever
its set to.Quoted 4 lines
so if one inherits
bin_packageand uses a "subdir" option, what is
installed (via tar) is the entire subdir directory structure, as infoo-1.0/*
That sounds more confusing.
Quoted 8 lines
The source component of
SRC_URIthat has subdir set against it is extracted to ${WORKDIR}/<subdir> rather than ${WORKDIR}/. Nothing more, nothing less.Quoted 2 lines
unless the recipe explicitly sets S to match it, is that it? that might be worth noting in the comments, then.
S has nothing to do with this so stop trying to include it.
i actually think we're agreeing here, i'm just explaining myself
badly. i'll try again later.
rday