usbhid : enable NO_INIT_REPORTS quirk for Semico USB Keykoard
PATCH 1/1 usbhid : enable NO_INIT_REPORTS quirk for Semico USB Keykoard
The device which identifies itself as a "USB Keykoard" (no typo) with VID:PID 1a2c:0023 does not seem to be handling the reports initialization very well. This results in a "usb_submit_urb(ctrl) failed: -1" message from the kernel when connected, and a delay before its initialization. This patch adds the quirk for this device, which causes the delay to disappear.
---
drivers/hid/hid-ids.h +4 -0
@@ -769,6 +769,10 @@#define USB_DEVICE_ID_SAMSUNG_IR_REMOTE 0x0001#define USB_DEVICE_ID_SAMSUNG_WIRELESS_KBD_MOUSE 0x0600 +/* China Resource Semico Co., Ltd */ +#define USB_VENDOR_ID_SEMICO 0x1a2c +#define USB_DEVICE_ID_SEMICO_USB_KEYKOARD 0x0023 +#define USB_VENDOR_ID_SENNHEISER 0x1395#define USB_DEVICE_ID_SENNHEISER_BTD500USB 0x002c
drivers/hid/usbhid/hid-quirks.c +1 -0
@@ -120,6 +120,7 @@ static const struct hid_blacklist { { USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_HD, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_QUAD_HD, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_TP_V103, HID_QUIRK_NO_INIT_REPORTS }, + { USB_VENDOR_ID_SEMICO, USB_DEVICE_ID_SEMICO_USB_KEYKOARD, HID_QUIRK_NO_INIT_REPORTS }, { 0, 0 } };
Quoted 7 lines · Daniel Kamil Kozar
The device which identifies itself as a "USB Keykoard" (no typo) with VID:PID 1a2c:0023 does not seem to be handling the reports initialization very well. This results in a "
usb_submit_urb(ctrl)failed: -1" message from the kernel when connected, and a delay before its initialization. This patch adds the quirk for this device, which causes the delay to disappear.Signed-off-by Daniel Kamil Kozar <[email protected]>
Please always add an empty line between the changelog and a signoff.
drivers/hid/hid-ids.h line 772
Quoted 9 lines
---
diff -uprN -X linux-3.15-rc7/Documentation/dontdifflinux-3.15-rc7/drivers/hid/hid-ids.hlinux-3.15-rc7-mine/drivers/hid/hid-ids.hdrivers/hid/hid-ids.h +1
-0@@ -769,6 +769,10 @@#define USB_DEVICE_ID_SAMSUNG_IR_REMOTE 0x0001#define USB_DEVICE_ID_SAMSUNG_WIRELESS_KBD_MOUSE 0x0600 +/* China Resource Semico Co., Ltd */
We're not putting such comments there.
Quoted 10 lines
drivers/hid/hid-ids.h +3
-0+#define USB_VENDOR_ID_SEMICO 0x1a2c +#define USB_DEVICE_ID_SEMICO_USB_KEYKOARD 0x0023 +#define USB_VENDOR_ID_SENNHEISER 0x1395#define USB_DEVICE_ID_SENNHEISER_BTD500USB 0x002cdiff -uprN -X linux-3.15-rc7/Documentation/dontdiff
linux-3.15-rc7/drivers/hid/usbhid/hid-quirks.clinux-3.15-rc7-mine/drivers/hid/usbhid/hid-quirks.c
drivers/hid/usbhid/hid-quirks.c static const struct hid_blacklist { · line 123
Quoted 4 lines
drivers/hid/usbhid/hid-quirks.c +1
-0@@ -120,6 +120,7 @@ static const struct hid_blacklist { { USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_HD, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_QUAD_HD, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_TP_V103, HID_QUIRK_NO_INIT_REPORTS }, + { USB_VENDOR_ID_SEMICO, USB_DEVICE_ID_SEMICO_USB_KEYKOARD, HID_QUIRK_NO_INIT_REPORTS },
The list ought to be kept sorted.
These were trivial to fix, so I have fixed it and applied, but please keep that in mind for your future patch submissions.
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs