Skip to contentSkip to conversation

Fix latency error check in pulse_delay()

DISCUSSION GitHub pull_request - opened 1 participant 2 messages Sep 21 – Oct 15 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): alsa-project/alsa-plugins/pr/[email protected]

GitHub pull_request - opened

author
#1 lore raw

alsa-project/alsa-plugins pull request #67 was opened from argothiel:

There is an issue with pulse_delay() which calls pa_stream_get_latency(). PulseAudio documents that this function returns -PA_ERR_NODATA when timing information is not available yet. The ALSA Pulse plugin compares the result against positive PA_ERR_NODATA; it therefore treats that temporary condition as an unrelated failure and returns -EIO.

Change PA_ERR_NODATA to -PA_ERR_NODATA in the comparison to not miss that branch.

Fixes #65.

Request URL : https://github.com/alsa-project/alsa-plugins/pull/67
Patch URL : https://github.com/alsa-project/alsa-plugins/pull/67.patch
Repository URL: https://github.com/alsa-project/alsa-plugins

author
#2 lore raw
In reply to a message not in the archive

alsa-project/alsa-plugins pull request #67 was reopened from argothiel:

There is an issue with pulse_delay() which calls pa_stream_get_latency(). PulseAudio documents that this function returns -PA_ERR_NODATA when timing information is not available yet. The ALSA Pulse plugin compares the result against positive PA_ERR_NODATA; it therefore treats that temporary condition as an unrelated failure and returns -EIO.

Change PA_ERR_NODATA to -PA_ERR_NODATA in the comparison to not miss that branch.

Fixes #65.

Request URL : https://github.com/alsa-project/alsa-plugins/pull/67
Patch URL : https://github.com/alsa-project/alsa-plugins/pull/67.patch
Repository URL: https://github.com/alsa-project/alsa-plugins