Skip to contentSkip to conversation

scsi: qla2xxx: Fix an error code in qla_get_tmf()

PATCH Applied Dan Carpenter 2 participants 3 messages Aug 13 – Aug 26

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: qla2xxx: Fix an error code in qla_get_tmf()

Negative -EIO was intended instead of positive EIO. The caller, doesn't care so this doesn't affect runtime. It's just a cleanup.

---
 drivers/scsi/qla2xxx/qla_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_init.c +1 -1
index 2b9a9c672ec6..0c4e8ce9decf 100644
@@ -2302,7 +2302,7 @@ int qla_get_tmf(struct tmf_arg *arg)
 		if (TMF_NOT_READY(fcport)) {
 			ql_log(ql_log_warn, vha, 0x802c,
 			    "Unable to acquire TM resource due to disruption.\n");
-			rc = EIO;
+			rc = -EIO;
 			break;
 		}
 		if (ha->active_tmf < MAX_ACTIVE_TMF &&
Signature · 1 line
2.53.0
maintainer Applied
#1 lore raw

Dan,

Quoted 2 lines

Negative -EIO was intended instead of positive EIO. The caller, doesn't care so this doesn't affect runtime. It's just a cleanup.

Applied to 7.3/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen