Skip to contentSkip to conversation

linux-next: build failure after merge of the gpio-brgl tree

DISCUSSION Mark Brown 2 participants 3 messages Sep 2 – Sep 3 Linux-next tree

lore
Share & tools
lore

Mark Brown

author maintainer
#0 lore raw

Hi all,

After merging the gpio-brgl tree, today's linux-next build (arm64 defconfig) failed like this:

/tmp/next/build/drivers/gpio/gpio-altera.c: In function 'altera_gpio_probe':
/tmp/next/build/drivers/gpio/gpio-altera.c:224:21: error: 'irq' undeclared (first use in this function); did you mean 'girq'?

  224 |                 if (irq != -ENXIO)
      |                     ^~~
      |                     girq

Caused by commit

6e6e585b603e4 (gpio: altera: Handle errors from optional IRQ lookup)

I have used the tree from 20260901 instead.

#1 lore raw

Hi Mark,

Thanks for the report.

Quoted 7 lines

/tmp/next/build/drivers/gpio/gpio-altera.c: In function 'altera_gpio_probe':
/tmp/next/build/drivers/gpio/gpio-altera.c:224:21: error: 'irq' undeclared (first use in this function); did you mean 'girq'?

  224 |                 if (irq != -ENXIO)
      |                     ^~~
      |                     girq

This was my mistake.
This issue was caused by using 'irq' instead of 'mapped_irq' in altera_gpio_probe().
I haven't encountered this situation before. Should I send a v2 with this fix, or should I send a separate patch to fix it?

Best regards,
Phuc