Skip to contentSkip to conversation

linux-next: build failure in the final build

DISCUSSION Mark Brown 2 participants 2 messages Sep 30 Linux-next tree

lore
Share & tools
lore

Mark Brown

author maintainer
#0 lore raw

Hi all,

In the final build today's linux-next build (powerpc allnoconfig) failed like this:

/tmp/next/build/lib/vdso/gettimeofday.c: In function '__cvdso_clock_gettime_common':
/tmp/next/build/lib/vdso/gettimeofday.c:288:31: error: implicit declaration of function 'BITS_PER_TYPE'; did you mean 'BITS_PER_LONG'? [-Wimplicit-function-declaration]

  288 |         BUILD_BUG_ON(clock >= BITS_PER_TYPE(msk));
      |                               ^~~~~~~~~~~~~
/tmp/next/build/include/linux/compiler_types.h:682:23: note: in definition of macro '__compiletime_assert'
  682 |                 if (!(condition))                                       \
      |                       ^~~~~~~~~
/tmp/next/build/include/linux/compiler_types.h:702:9: note: in expansion of macro '_compiletime_assert'
  702 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
      |         ^~~~~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/build_bug.h:40:37: note: in expansion of macro 'compiletime_assert'
   40 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
      |                                     ^~~~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/build_bug.h:51:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
   51 |         BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
      |         ^~~~~~~~~~~~~~~~
/tmp/next/build/lib/vdso/gettimeofday.c:288:9: note: in expansion of macro 'BUILD_BUG_ON'
  288 |         BUILD_BUG_ON(clock >= BITS_PER_TYPE(msk));
      |         ^~~~~~~~~~~~

Caused by commit

ca46a07c4b682 (vdso/gettimeofday: Assert that the clockid fits into the u32 bitmask)

I reverted that commit for today.

#1 lore raw

Hi Mark,

Quoted 23 lines · Mark Brown

In the final build today's linux-next build (powerpc allnoconfig) failed like this:

/tmp/next/build/lib/vdso/gettimeofday.c: In function '__cvdso_clock_gettime_common':
/tmp/next/build/lib/vdso/gettimeofday.c:288:31: error: implicit declaration of function 'BITS_PER_TYPE'; did you mean 'BITS_PER_LONG'? [-Wimplicit-function-declaration]

  288 |         BUILD_BUG_ON(clock >= BITS_PER_TYPE(msk));
      |                               ^~~~~~~~~~~~~
/tmp/next/build/include/linux/compiler_types.h:682:23: note: in definition of macro '__compiletime_assert'
  682 |                 if (!(condition))                                       \
      |                       ^~~~~~~~~
/tmp/next/build/include/linux/compiler_types.h:702:9: note: in expansion of macro '_compiletime_assert'
  702 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
      |         ^~~~~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/build_bug.h:40:37: note: in expansion of macro 'compiletime_assert'
   40 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
      |                                     ^~~~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/build_bug.h:51:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
   51 |         BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
      |         ^~~~~~~~~~~~~~~~
/tmp/next/build/lib/vdso/gettimeofday.c:288:9: note: in expansion of macro 'BUILD_BUG_ON'
  288 |         BUILD_BUG_ON(clock >= BITS_PER_TYPE(msk));
      |         ^~~~~~~~~~~~
Quoted 5 lines

Caused by commit

ca46a07c4b682 (vdso/gettimeofday: Assert that the clockid fits into the u32 bitmask)

I reverted that commit for today.

It got also pulled from the tip tree:
https://lore.kernel.org/lkml/874if6j4if.ffs@fw13/

Thomas