Missing signoff in the drivers-x86 tree
Mark Brown
maintainerCommits
4dabecbb202e8 ("platform/x86: hp-wmi: add Omen Transcend 14 8C58 support") 9af7fddef448d ("platform/x86: asus-wmi: suppress -ENODEV warning in fan_curve_get_factory_default()")
are missing a Signed-off-by from their authors
Mark Brown
maintainerQuoted 6 lines · Mark Brown
Commits
4dabecbb202e8("platform/x86: hp-wmi: add Omen Transcend 14 8C58 support")9af7fddef448d("platform/x86: asus-wmi: suppress-ENODEVwarning infan_curve_get_factory_default()")are missing a Signed-off-by from their authors
This issue is still present today.
Mark Brown
maintainerQuoted 9 lines · Mark Brown
Quoted 6 lines · Mark Brown
Commits
4dabecbb202e8("platform/x86: hp-wmi: add Omen Transcend 14 8C58 support")9af7fddef448d("platform/x86: asus-wmi: suppress-ENODEVwarning infan_curve_get_factory_default()")are missing a Signed-off-by from their authors
This issue is still present today.
And today.
Mark Brown
maintainerQuoted 4 lines · Mark Brown
Quoted 3 lines · Mark Brown
Quoted 2 lines · Mark Brown
Commits
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
4dabecbb202e8("platform/x86: hp-wmi: add Omen Transcend 14 8C58 support")9af7fddef448d("platform/x86: asus-wmi: suppress-ENODEVwarning infan_curve_get_factory_default()")are missing a Signed-off-by from their authors
This issue is still present today.
And today.
And today - should Ilpo be added to the list of contacts for this tree?
Quoted 8 lines · Mark Brown
Quoted 7 lines · Mark Brown
Quoted 6 lines · Mark Brown
Quoted 5 lines · Mark Brown
Commits
4dabecbb202e8("platform/x86: hp-wmi: add Omen Transcend 14 8C58 support")9af7fddef448d("platform/x86: asus-wmi: suppress-ENODEVwarning infan_curve_get_factory_default()")
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
are missing a Signed-off-by from their authors
This issue is still present today.
And today.
And today - should Ilpo be added to the list of contacts for this tree?
Yeah, I'm in practice the person who is handling pdx86 patches these days so it would be good.
...Goes to do some massive history rewriting...
Signature · 1 line
i.
Hi,
Quoted 14 lines · Ilpo Järvinen
Quoted 12 lines · Mark Brown
Quoted 11 lines · Mark Brown
Quoted 9 lines · Mark Brown
Quoted 6 lines · Mark Brown
Commits
4dabecbb202e8("platform/x86: hp-wmi: add Omen Transcend 14 8C58 support")9af7fddef448d("platform/x86: asus-wmi: suppress-ENODEVwarning infan_curve_get_factory_default()")are missing a Signed-off-by from their authors
This issue is still present today.
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
And today.
And today - should Ilpo be added to the list of contacts for this tree?
Yeah, I'm in practice the person who is handling pdx86 patches these days so it would be good.
...Goes to do some massive history rewriting...
My bad, I missed you (Ilpo) were not getting these emails, sorry.
Regards,
Hans
Quoted 17 lines · Hans de Goede
Quoted 16 lines · Ilpo Järvinen
Quoted 14 lines · Mark Brown
Quoted 12 lines · Mark Brown
Quoted 9 lines · Mark Brown
Quoted 6 lines · Mark Brown
Commits
4dabecbb202e8("platform/x86: hp-wmi: add Omen Transcend 14 8C58 support")9af7fddef448d("platform/x86: asus-wmi: suppress-ENODEVwarning infan_curve_get_factory_default()")are missing a Signed-off-by from their authors
This issue is still present today.
And today.
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
And today - should Ilpo be added to the list of contacts for this tree?
Yeah, I'm in practice the person who is handling pdx86 patches these days so it would be good.
...Goes to do some massive history rewriting...
My bad, I missed you (Ilpo) were not getting these emails, sorry.
I finally went and improved my patch getting script to block any submissions for which git interpret-trailers shows no Sign-off-by lines. That'll make it in practice impossible for me to apply such submissions anymore.
It's not entirely foolproof though as the Signed-off-by could still be invalid one e.g. by being different from From and I don't know easy way to extract From from a patch file (consider encodings and multiple From lines properly).
Signature · 1 line
i.
Mark Brown
maintainerQuoted 4 lines · Ilpo Järvinen
It's not entirely foolproof though as the Signed-off-by could still be invalid one e.g. by being different from From and I don't know easy way to extract From from a patch file (consider encodings and multiple From lines properly).
The script -next uses is:
https://git.kernel.org/pub/scm/utils/next-utils/tools.git/tree/check_commits?h=main
Greg K-H has a script a bunch of people use which is a bit more friendly for using in commit hooks and whatever, I don't have a URL to hand for it immediately though.
Mark Brown
maintainerQuoted 8 lines · Mark Brown
Quoted 7 lines · Mark Brown
Quoted 6 lines · Mark Brown
Quoted 5 lines · Mark Brown
Commits
4dabecbb202e8("platform/x86: hp-wmi: add Omen Transcend 14 8C58 support")9af7fddef448d("platform/x86: asus-wmi: suppress-ENODEVwarning infan_curve_get_factory_default()")
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
are missing a Signed-off-by from their authors
This issue is still present today.
And today.
And today - should Ilpo be added to the list of contacts for this tree?
And today.
Quoted 11 lines · Mark Brown
Quoted 10 lines · Mark Brown
Quoted 9 lines · Mark Brown
Quoted 8 lines · Mark Brown
Quoted 6 lines · Mark Brown
Commits
4dabecbb202e8("platform/x86: hp-wmi: add Omen Transcend 14 8C58 support")9af7fddef448d("platform/x86: asus-wmi: suppress-ENODEVwarning infan_curve_get_factory_default()")are missing a Signed-off-by from their authors
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
This issue is still present today.
And today.
And today - should Ilpo be added to the list of contacts for this tree?
And today.
Hi Mark,
Something odd is likely going on here. Neither of those commits above are in my tree anymore.
Your latest merge:
commit 233956951080612ff68d0c54f620606c53a1c91c
Merge: 67f116b3a9f8 98f039265e58 Author: Mark Brown <[email protected]> AuthorDate: Mon Oct 19 17:58:11 2026 +0100 Commit: Mark Brown <[email protected]> CommitDate: Mon Oct 19 17:58:11 2026 +0100
Merge branch 'for-next' of https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
I don't know how you got that 98f039265e58 but that hasn't been in pdx86 tree for multiple days by now:
$ git log ea40f1e9f07aab937b9a217633be7a1f66260394 | grep -e 4dabecbb202e8 -e 9af7fddef448d
Signature · 1 line
i.
Mark Brown
maintainerQuoted 5 lines · Ilpo Järvinen
Something odd is likely going on here. Neither of those commits above are in my tree anymore.
Your latest merge:
Quoted 7 lines
commit
233956951080612ff68d0c54f620606c53a1c91c
Merge:67f116b3a9f898f039265e58I don't know how you got that
98f039265e58but that hasn't been in pdx86 tree for multiple days by now:
That's what I fetched yesterday, I don't know if there was some infra issue which caused the fetch to fail. What I'm seeing for today is commit 893018d51f27ec0449155b0afe371aaf65380630, hopefully that's what you expected.
Quoted 13 lines · Mark Brown
Quoted 10 lines · Ilpo Järvinen
Something odd is likely going on here. Neither of those commits above are in my tree anymore.
Your latest merge:
commit
233956951080612ff68d0c54f620606c53a1c91c
Merge:67f116b3a9f898f039265e58I don't know how you got that
98f039265e58but that hasn't been in pdx86 tree for multiple days by now:
Quoted 6 lines
That's what I fetched yesterday, I don't know if there was some infra issue which caused the fetch to fail. What I'm seeing for today is commit
893018d51f27ec0449155b0afe371aaf65380630, hopefully that's what you expected.
893018d51f27ec0449155b0afe371aaf65380630 should no longer have the issue and is the current for-next head.
Have a nice day. :-)
Signature · 1 line
i.