Skip to contentSkip to conversation

Missing signoff in the perf tree

DISCUSSION Mark Brown 3 participants 3 messages Sep 24 Linux-next tree

lore
Share & tools
lore

Mark Brown

author maintainer
#0 lore raw

Commit

4c09f6c47b769 ("perf annotate: Fix NULL pointer dereference in loongarch_call__parse")

is missing a Signed-off-by from its author

#1 lore raw
Quoted 5 lines · Mark Brown

Commit

4c09f6c47b769 ("perf annotate: Fix NULL pointer dereference in loongarch_call__parse")

is missing a Signed-off-by from its author

I'll fix and force push.

- Arnaldo

Reviewed-by Ming Wang
#2 lore raw
In reply to Mark Brown
Quoted 5 lines · Mark Brown

Commit

4c09f6c47b769 ("perf annotate: Fix NULL pointer dereference in loongarch_call__parse")

is missing a Signed-off-by from its author

The patch had a --- before the author's s-o-b, so it got lost, I'll adding it and will force push:

============================================================

the address-based symbol lookup so that ops->target.sym can still be resolved via maps__find_ams() using the already-parsed target address. This preserves is_call semantics and keeps TUI navigation working.

---
Changes from v1:
- Instead of returning -1 when the '<sym>' token is absent jump to the address-based symbol lookup so that maps__find_ams() can still resolve ops->target.sym from the already parsed target address.

- Link to v1: https://lore.kernel.org/all/[email protected]/
---

Fixes 4ca0d340ce20 ("perf annotate: Fix instruction association and parsing for LoongArch")

======================

- Arnaldo