Skip to contentSkip to conversation

linux-next: build failure after merge of the hid tree

DISCUSSION Mark Brown 2 participants 2 messages Oct 16 Linux-next tree

lore
Share & tools
lore

Mark Brown

author maintainer
#0 lore raw

Hi all,

After merging the hid tree, today's linux-next build (x86_64 allmodconfig) failed like this:

/tmp/next/build/drivers/hid/hid-pulsar.c:742:4: error: expected '}'

  742 |           .driver_data = TYPE_KYSONA },
      |           ^

/tmp/next/build/drivers/hid/hid-pulsar.c:730:52: note: to match this '{'
730 | static const struct hid_device_id pulsar_table[] = {
| ^
/tmp/next/build/drivers/hid/hid-pulsar.c:742:32: error: expected ';' at end of declaration

  742 |           .driver_data = TYPE_KYSONA },
      |                                       ^
      |                                       ;
/tmp/next/build/drivers/hid/hid-pulsar.c:743:2: error: expected identifier or '('
  743 |         { HID_USB_DEVICE(USB_VENDOR_ID_ATK, USB_DEVICE_ID_ATK_VXE_R1_SE_WIRED),
      |         ^
/tmp/next/build/drivers/hid/hid-pulsar.c:752:1: error: extraneous closing brace ('}')
  752 | };
      | ^
/tmp/next/build/drivers/hid/hid-pulsar.c:767:1: error: definition of variable with array type needs an explicit size or an initializer
  767 | MODULE_DEVICE_TABLE(hid, pulsar_table);
      | ^

/tmp/next/build/include/linux/module.h:256:21: note: expanded from macro 'MODULE_DEVICE_TABLE'
256 | static typeof(name) __mod_device_table(type, name) \
| ^
/tmp/next/build/include/linux/module.h:247:2: note: expanded from macro '__mod_device_table'

  247 |         __PASTE(__mod_device_table__,   \
      |         ^

/tmp/next/build/include/linux/compiler_types.h:16:23: note: expanded from macro '__PASTE'
16 | #define __PASTE(a, b) ___PASTE(a, b)
| ^
/tmp/next/build/include/linux/compiler_types.h:15:24: note: expanded from macro '___PASTE'
15 | #define ___PASTE(a, b) a##b
| ^
<scratch space>:37:1: note: expanded from here
37 | __mod_device_table__kmod_hid_pulsar__hid__pulsar_table

      | ^

5 errors generated.

Caused by commit

e55cf379e822b (HID: pulsar: add driver for Pulsar gaming mice)

I have used the tree from next-20261015 instead.

#1 lore raw
Quoted 8 lines · Mark Brown

Hi all,

After merging the hid tree, today's linux-next build (x86_64 allmodconfig) failed like this:

/tmp/next/build/drivers/hid/hid-pulsar.c:742:4: error: expected '}'

  742 |           .driver_data = TYPE_KYSONA },
      |           ^

Yeah, that's me fat-fingering drivial merge conflict resolution and not noticing, sorry for that.

I've now pushed for-next that has this fixed.

Signature · 2 lines
Jiri Kosina
SUSE Labs