Skip to contentSkip to conversation

package/erlang: enable uClibc support

PATCH In review Waldemar Brodkorb 2 participants 3 messages Oct 18 – Oct 19

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/erlang: enable uClibc support

uClibc support was disabled in commit:
fb72418160417e9e872f626c356f898bff49cf48. This problem is solved in 1.0.59. So in internal Buildroot toolchains and external Bootlin toolchains.

The change can be backported to stable branches.

Tested with aarch64 and external uClibc Bootlin toolchain.

---
 package/erlang/Config.in | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
package/erlang/Config.in +2 -3
index 724f91123b..d3fe0dbec1 100644
@@ -15,11 +15,11 @@ config BR2_PACKAGE_ERLANG_ARCH_SUPPORTS
 	# erlang needs host-erlang
 	depends on BR2_PACKAGE_HOST_ERLANG_ARCH_SUPPORTS
 
-comment "erlang needs a glibc or musl toolchain w/ dynamic library, threads, wchar"
+comment "erlang needs a toolchain w/ dynamic library, threads, wchar"
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_PACKAGE_ERLANG_ARCH_SUPPORTS
 	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS \
-		|| !BR2_USE_WCHAR || BR2_TOOLCHAIN_USES_UCLIBC
+		|| !BR2_USE_WCHAR
 
 config BR2_PACKAGE_ERLANG
 	bool "erlang"
@@ -27,7 +27,6 @@ config BR2_PACKAGE_ERLANG
 	depends on BR2_USE_WCHAR
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_TOOLCHAIN_HAS_THREADS
-	depends on !BR2_TOOLCHAIN_USES_UCLIBC
 	depends on BR2_PACKAGE_ERLANG_ARCH_SUPPORTS
 	select BR2_PACKAGE_ZLIB
 	help
Signature · 6 lines
2.47.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Reviewed-by Thomas Perale on v1 1/1
#1 lore raw

Hello,

Also tested with the erlang test modified to use uclibc:

```diff
diff --git a/support/testing/tests/package/test_erlang.py b/support/testing/tests/package/test_erlang.py
index a765cec843..e39bd94b4e 100644
--- a/support/testing/tests/package/test_erlang.py
+++ b/support/testing/tests/package/test_erlang.py
@@ -4,8 +4,15 @@ import infra.basetest
 
 
 class TestErlang(infra.basetest.BRTest):
-    config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
+    config = \
         """
+        BR2_arm=y
+        BR2_cortex_a9=y
+        BR2_ARM_ENABLE_VFP=y
+        BR2_ARM_EABIHF=y
+        BR2_TOOLCHAIN_EXTERNAL=y
+        BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
+        BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_ARMV7_EABIHF_UCLIBC_BLEEDING_EDGE=y
         BR2_PACKAGE_ERLANG=y
         BR2_TARGET_ROOTFS_CPIO=y
         # BR2_TARGET_ROOTFS_TAR is not set
```

Best regards,
PERALE Thomas

In reply of:

Quoted 48 lines

uClibc support was disabled in commit:
fb72418160417e9e872f626c356f898bff49cf48. This problem is solved in 1.0.59. So in internal Buildroot toolchains and external Bootlin toolchains.

The change can be backported to stable branches.

Tested with aarch64 and external uClibc Bootlin toolchain.

---
 package/erlang/Config.in | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
package/erlang/Config.in +2 -3
index 724f91123b..d3fe0dbec1 100644
@@ -15,11 +15,11 @@ config BR2_PACKAGE_ERLANG_ARCH_SUPPORTS
 	# erlang needs host-erlang
 	depends on BR2_PACKAGE_HOST_ERLANG_ARCH_SUPPORTS
 
-comment "erlang needs a glibc or musl toolchain w/ dynamic library, threads, wchar"
+comment "erlang needs a toolchain w/ dynamic library, threads, wchar"
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_PACKAGE_ERLANG_ARCH_SUPPORTS
 	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS \
-		|| !BR2_USE_WCHAR || BR2_TOOLCHAIN_USES_UCLIBC
+		|| !BR2_USE_WCHAR
 
 config BR2_PACKAGE_ERLANG
 	bool "erlang"
@@ -27,7 +27,6 @@ config BR2_PACKAGE_ERLANG
 	depends on BR2_USE_WCHAR
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_TOOLCHAIN_HAS_THREADS
-	depends on !BR2_TOOLCHAIN_USES_UCLIBC
 	depends on BR2_PACKAGE_ERLANG_ARCH_SUPPORTS
 	select BR2_PACKAGE_ZLIB
 	help
Signature · 6 lines
2.47.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
In reply to Waldemar Brodkorb
Quoted 6 lines · Waldemar Brodkorb

uClibc support was disabled in commit:
fb72418160417e9e872f626c356f898bff49cf48. This problem is solved in 1.0.59. So in internal Buildroot toolchains and external Bootlin toolchains.

The change can be backported to stable branches.

This change is a new feature, i.e it allows things that were not possible before. As such, there is no point in backporting it to stable branches.

Quoted 3 lines

Tested with aarch64 and external uClibc Bootlin toolchain.

Applied after tweaking the commit log, thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot