Skip to contentSkip to conversation

ALSA: usb-audio: Add always_set_rate quirk for Yamaha MODX M

PATCH In review Geoffrey D. Bennett 3 participants 3 messages Nov 15 – Nov 16 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: usb-audio: Add always_set_rate quirk for Yamaha MODX M

The Yamaha MODX M uses a different USB ID for each combination of its audio mode and MIDI version settings:

  0499:1772  2 stereo, 44.1-96 kHz, MIDI 1.0
  0499:1763  2 stereo, 44.1-96 kHz, MIDI 2.0
  0499:1773  5 stereo, 44.1 kHz, MIDI 1.0
  0499:1764  5 stereo, 44.1 kHz, MIDI 2.0

With 0499:1773 and 0499:1764 playback is silent. With the always_set_rate quirk flag set for them it plays. 0499:1772 and 0499:1763 play without it.

Tested on a MODX M6 with the quirk_flags module parameter set to 0499:1773:always_set_rate and to 0499:1764:always_set_rate.

---
 sound/usb/quirks.c | 4 ++++
 1 file changed, 4 insertions(+)
sound/usb/quirks.c +4 -0
index 7c581e283903..0a91a67d824f 100644
@@ -2558,6 +2558,10 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
 		   QUIRK_FLAG_GENERIC_IMPLICIT_FB),
 	DEVICE_FLG(0x0499, 0x1516, /* Yamaha ZG02 */
 		   QUIRK_FLAG_GENERIC_IMPLICIT_FB),
+	DEVICE_FLG(0x0499, 0x1764, /* Yamaha MODX M, 5 stereo, MIDI 2.0 */
+		   QUIRK_FLAG_ALWAYS_SET_RATE),
+	DEVICE_FLG(0x0499, 0x1773, /* Yamaha MODX M, 5 stereo, MIDI 1.0 */
+		   QUIRK_FLAG_ALWAYS_SET_RATE),
 	DEVICE_FLG(0x0499, 0x3108, /* Yamaha YIT-W12TX */
 		   QUIRK_FLAG_GET_SAMPLE_RATE),
 	DEVICE_FLG(0x04d8, 0xfeea, /* Benchmark DAC1 Pre */
Signature · 1 line
2.56.0
#1 lore raw

Hi Geoffrey,

Though won't related to the actual patch but that 96khz mode is actually 1 stereo mode. XD

Best regards,
Shengyu

Quoted 39 lines · Geoffrey D. Bennett

The Yamaha MODX M uses a different USB ID for each combination of its audio mode and MIDI version settings:

   0499:1772  2 stereo, 44.1-96 kHz, MIDI 1.0
   0499:1763  2 stereo, 44.1-96 kHz, MIDI 2.0
   0499:1773  5 stereo, 44.1 kHz, MIDI 1.0
   0499:1764  5 stereo, 44.1 kHz, MIDI 2.0

With 0499:1773 and 0499:1764 playback is silent. With the always_set_rate quirk flag set for them it plays. 0499:1772 and 0499:1763 play without it.

Tested on a MODX M6 with the quirk_flags module parameter set to 0499:1773:always_set_rate and to 0499:1764:always_set_rate.

---
  sound/usb/quirks.c | 4 ++++
  1 file changed, 4 insertions(+)
sound/usb/quirks.c +4 -0
index 7c581e283903..0a91a67d824f 100644
@@ -2558,6 +2558,10 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
  		   QUIRK_FLAG_GENERIC_IMPLICIT_FB),
  	DEVICE_FLG(0x0499, 0x1516, /* Yamaha ZG02 */
  		   QUIRK_FLAG_GENERIC_IMPLICIT_FB),
+	DEVICE_FLG(0x0499, 0x1764, /* Yamaha MODX M, 5 stereo, MIDI 2.0 */
+		   QUIRK_FLAG_ALWAYS_SET_RATE),
+	DEVICE_FLG(0x0499, 0x1773, /* Yamaha MODX M, 5 stereo, MIDI 1.0 */
+		   QUIRK_FLAG_ALWAYS_SET_RATE),
  	DEVICE_FLG(0x0499, 0x3108, /* Yamaha YIT-W12TX */
  		   QUIRK_FLAG_GET_SAMPLE_RATE),
  	DEVICE_FLG(0x04d8, 0xfeea, /* Benchmark DAC1 Pre */
#2 lore raw
In reply to Geoffrey D. Bennett
Quoted 13 lines · Geoffrey D. Bennett

The Yamaha MODX M uses a different USB ID for each combination of its audio mode and MIDI version settings:

  0499:1772  2 stereo, 44.1-96 kHz, MIDI 1.0
  0499:1763  2 stereo, 44.1-96 kHz, MIDI 2.0
  0499:1773  5 stereo, 44.1 kHz, MIDI 1.0
  0499:1764  5 stereo, 44.1 kHz, MIDI 2.0

With 0499:1773 and 0499:1764 playback is silent. With the always_set_rate quirk flag set for them it plays. 0499:1772 and 0499:1763 play without it.

Quoted 8 lines

Tested on a MODX M6 with the quirk_flags module parameter set to 0499:1773:always_set_rate and to 0499:1764:always_set_rate.

Applied now. Thanks.

Takashi