Driver for Nuvoton NCT6687D eSIO chip
To whom it may concern,
I am trying to submit a patch for driver Driver for Nuvoton NCT6687D eSIO chip under drivers/hwmon. This driver is confirmed to be working for motherboards series B550 and B650.
Credits for creating this driver should go to Frederic BOLTZ https://github.com/Fred78290/nct6687d
Attached is my patch
drivers/hwmon/Kconfig +10 -0
@@ -1518,6 +1518,16 @@ config SENSORS_NCT6683 This driver can also be built as a module. If so, the module will be called nct6683. +config SENSORS_NCT6687 + tristate "Nuvoton NCT6687D" + depends on !PPC + help + If you say yes here you get support for the hardware monitoring + functionality of the Nuvoton NCT6687D eSIO chip. + + This driver can also be built as a module. If so, the module + will be called nct6687. + config SENSORS_NCT6775_CORE tristate select REGMAP
drivers/hwmon/Makefile +1 -0
@@ -158,6 +158,7 @@ obj-$(CONFIG_SENSORS_MLXREG_FAN) += mlxreg-fan.o obj-$(CONFIG_SENSORS_MENF21BMC_HWMON) += menf21bmc_hwmon.o obj-$(CONFIG_SENSORS_MR75203) += mr75203.o obj-$(CONFIG_SENSORS_NCT6683) += nct6683.o +obj-$(CONFIG_SENSORS_NCT6687) += nct6687.o obj-$(CONFIG_SENSORS_NCT6775_CORE) += nct6775-core.o nct6775-objs := nct6775-platform.o obj-$(CONFIG_SENSORS_NCT6775) += nct6775.o
drivers/hwmon/nct6687.c new file +1272 -0
1,272 lines not on this page · raw message
From 8c49ae386d76ebdf6ca99102eaa50fc9eaba84a1 Mon Sep 17 00:00:00 2001
From: Thomas Raines <[email protected]>
Date: Sun, 16 Jul 2023 07:53:30 -0500
Subject: [PATCH] Adding driver for NCT6687D Kernel module. Original author is
Frederic BOLTZ https://github.com/Fred78290/nct6687d.
--- drivers/hwmon/Kconfig | 10 + drivers/hwmon/Makefile | 1 + drivers/hwmon/nct6687.c | 1272 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 1283 insertions(+) create mode 100644 drivers/hwmon/nct6687.c
drivers/hwmon/Kconfig +10 -0
@@ -1518,6 +1518,16 @@ config SENSORS_NCT6683 This driver can also be built as a module. If so, the module will be called nct6683. +config SENSORS_NCT6687 + tristate "Nuvoton NCT6687D" + depends on !PPC + help + If you say yes here you get support for the hardware monitoring + functionality of the Nuvoton NCT6687D eSIO chip. + + This driver can also be built as a module. If so, the module + will be called nct6687. + config SENSORS_NCT6775_CORE tristate select REGMAP
drivers/hwmon/Makefile +1 -0
@@ -158,6 +158,7 @@ obj-$(CONFIG_SENSORS_MLXREG_FAN) += mlxreg-fan.o obj-$(CONFIG_SENSORS_MENF21BMC_HWMON) += menf21bmc_hwmon.o obj-$(CONFIG_SENSORS_MR75203) += mr75203.o obj-$(CONFIG_SENSORS_NCT6683) += nct6683.o +obj-$(CONFIG_SENSORS_NCT6687) += nct6687.o obj-$(CONFIG_SENSORS_NCT6775_CORE) += nct6775-core.o nct6775-objs := nct6775-platform.o obj-$(CONFIG_SENSORS_NCT6775) += nct6775.o
drivers/hwmon/nct6687.c new file +1272 -0
1,272 lines not on this page · raw message
Signature · 1 line
2.34.1
Guenter Roeck
maintainerQuoted 7 lines · Thomas R
To whom it may concern,
I am trying to submit a patch for driver Driver for Nuvoton NCT6687D eSIO chip under
drivers/hwmon. This driver is confirmed to be working for motherboards series B550 and B650.Credits for creating this driver should go to Frederic BOLTZ https://github.com/Fred78290/nct6687d
Attached is my patch
This is not the way to submit patches into the Linux kernel.
Anyway, this is pretty much just taking the existing nct6683 driver, extending it with an additional ID for NCT6687 (0xd451), removing customer ID checks, and claiming new authorship. No, this is not how kernel development works. If those motherboards use an NCT6687 with ID 0xd451, or if the boards use a new customer ID, submit patches updating the existing driver. If there are other changes improving the existing driver, submit patches for it. I am not going to accept a second driver for the same chip.
Guenter