Skip to contentSkip to conversation

Sick VFS question

DISCUSSION H. Peter Anvin 5 participants 13 messages Feb 25, 2003 – Mar 6, 2003 VFS

lore
Share & tools
lore
#0 lore raw

Hi everyone,

I'm considering new ideas for autofs v5, and I have a sick question:
would the VFS barf completely if autofs would take a dentry belonging to another filesystem and replace the inode pointer with a pointer to an inode belonging to itself (obviously incrementing the counter on that inode appropriately)? This would in particular be applicable to "mount pads", i.e. let's say /auto is an autofs, and /auto/foo is an autofs mount key, containing two filesystems: /auto/foo and /auto/foo/bar. After mounting /auto/foo, autofs would access the "bar" directory in the "foo" filesystem, and replace that inode with an internal autofs inode.
This internal inode would have a follow_link(!) method which would cause the /auto/foo/bar mount to happen and then redirect the search to the topmost directory.

Ideally, this should not impede a umount of the /auto/foo directory if the /auto/foo/bar directory is not mounted.

Using follow_link this way solves a whole lot of problems in autofs, both in terms of usability and atomicity. It solves the same problem the dentry traps was supposed to solve, but also avoids the "mount storm" problem by allowing lstat() without triggering a mount.

I would appreciate comments...

-hpa

Signature · 3 lines
<[email protected]> at work, <[email protected]> in private!
"Unix gives you enough rope to shoot yourself in the foot."
Architectures needed: cris ia64 m68k mips64 ppc ppc64 s390 s390x sh v850 x86-64
#1 lore raw
Quoted 7 lines · H. Peter Anvin

Hi everyone,

I'm considering new ideas for autofs v5, and I have a sick question:
would the VFS barf completely if autofs would take a dentry belonging to another filesystem and replace the inode pointer with a pointer to an inode belonging to itself (obviously incrementing the counter on that inode appropriately)?

This is precisely what we're doing in FiST-lite, so the answer is "it's OK in 2.4, at the very least".

There are some tricky things involved and you need to be extra careful about refcounts and all, but it's doable.

Quoted 6 lines

This internal inode would have a follow_link(!) method which would cause the /auto/foo/bar mount to happen and then redirect the search to the topmost directory.

Ideally, this should not impede a umount of the /auto/foo directory if the /auto/foo/bar directory is not mounted.

Hmm. That's a bit difficult. In order to keep control of that internal inode, you need to lock it in memory => unmountable fs. Otherwise, since /auto/foo is a separate, non-autofs f/s, autofs won't even see when /auto/foo is being looked up, so it can't redo the inode substitution trick on each lookup if/when the dentry is evicted...

Ion

Signature · 2 lines
  It is better to keep your mouth shut and be thought a fool,
            than to open it and remove all doubt.
#2 lore raw
Quoted 11 lines · Ion Badulescu
Quoted 7 lines · H. Peter Anvin

Hi everyone,

I'm considering new ideas for autofs v5, and I have a sick question:
would the VFS barf completely if autofs would take a dentry belonging to another filesystem and replace the inode pointer with a pointer to an inode belonging to itself (obviously incrementing the counter on that inode appropriately)?

This is precisely what we're doing in FiST-lite, so the answer is "it's OK in 2.4, at the very least".

I don't believe this is the case.

I think what was suggested is EXT2 dentry (or other "real" fs) points to an autofs inode. I'm not sure if this would work or not, but I don't think it is the same as FiST-lite.

AFAIK, In FiST-lite what happens is the upper level (wrapfs) inode has its address space operations set to the operations of the lower level (e.g., EXT2) inode. A quick look at the code seemed to confirm this.

The EXT2 dentry still points to the inode of ext2, and the wrapfs dentry still points to a wrapfs inode. The change is wrapfs inode's i_mapping->a_ops points to the EXT2 inode's i_mapping->a_ops.

Charles

#3 lore raw
Quoted 7 lines · Charles P. Wright

I don't believe this is the case.

I think what was suggested is EXT2 dentry (or other "real" fs) points to an autofs inode. I'm not sure if this would work or not, but I don't think it is the same as FiST-lite.

That is, indeed, what I'm trying to accomplish.

Quoted 7 lines

AFAIK, In FiST-lite what happens is the upper level (wrapfs) inode has its address space operations set to the operations of the lower level (e.g., EXT2) inode. A quick look at the code seemed to confirm this.

The EXT2 dentry still points to the inode of ext2, and the wrapfs dentry still points to a wrapfs inode. The change is wrapfs inode's i_mapping->a_ops points to the EXT2 inode's i_mapping->a_ops.

This sounds like it takes a file and "maps" it on top of another file -- something that would probably make a viable implementation of cachefs if we'd ever get around to implementing that...

-hpa

#4 lore raw
In reply to Charles P. Wright
Quoted 3 lines · Charles P. Wright

AFAIK, In FiST-lite what happens is the upper level (wrapfs) inode has its address space operations set to the operations of the lower level (e.g., EXT2) inode. A quick look at the code seemed to confirm this.

Hmm. You're probably right (you've been hacking that code more recently than I have...). Anyway, what I said initially was definitely the original approach for FiST-lite, and I guess my memory is getting fuzzy on recent details, even though I actively worked on them. :-)

Anyway, in that case, why couldn't autofs do the same kind of sick thing -- even sicker: make a private copy of ext2's (or whatever) i_op table for that inode and replace only the follow_link method inside it with its own?

There are some memory management issues there, but they look solvable. E.g. you only need to free up those private i_op structures when destroying the autofs superblock. Or perhaps increment the i_count in the inode so it doesn't get destroyed, and periodically go through the list of inodes checking if their i_count has dropped to 1 and free them. There could be other creative solutions as well... but I'm seriously wondering if any of this has a snowball's chance in hell of getting accepted by Linus.

Ion

Signature · 2 lines
  It is better to keep your mouth shut and be thought a fool,
            than to open it and remove all doubt.
#5 lore raw
Quoted 6 lines · Ion Badulescu

Anyway, in that case, why couldn't autofs do the same kind of sick thing -- even sicker: make a private copy of ext2's (or whatever) i_op table for that inode and replace only the follow_link method inside it with its own?

It seems a lot uglier than what I proposed, though. I would prefer not to have to create such "hack inodes", especially since some filesystems legitimately change their i_ops around with time.

-hpa

#6 lore raw
Quoted 3 lines · H. Peter Anvin

It seems a lot uglier than what I proposed, though. I would prefer not to have to create such "hack inodes", especially since some filesystems legitimately change their i_ops around with time.

Unfortunately, you might not be able to do what you originally wanted. The more control you give to the "slave" filesystem, the harder it gets to keep things sane, and I'd guesstimate that it becomes next to impossible if the slave has the upper hand (i.e. the dentry).

Direct mounts would solve all these issues in a much more elegant way. We already have overlay mounts, we already have bind mounts, all the elements are in place to support direct mounts without much effort.

Ion

Signature · 2 lines
  It is better to keep your mouth shut and be thought a fool,
            than to open it and remove all doubt.
#7 lore raw
Quoted 3 lines · Ion Badulescu

Direct mounts would solve all these issues in a much more elegant way. We already have overlay mounts, we already have bind mounts, all the elements are in place to support direct mounts without much effort.

Looking at the VFS code, it seems that all you need is a follow_link() autofs method which makes an upcall and then calls follow_mount(). This also has the nice property that the follow_link() code is completely bypassed on the lookup path, after a successful mount.

Ion

Signature · 2 lines
  It is better to keep your mouth shut and be thought a fool,
            than to open it and remove all doubt.
#8 lore raw
In reply to Ion Badulescu
Quoted 5 lines · Ion Badulescu

Direct mounts would solve all these issues in a much more elegant way. We already have overlay mounts, we already have bind mounts, all the elements are in place to support direct mounts without much effort.

Yes, except for atomicity concerns. Anyway, I had a talk with Linus about this about an hour ago, and he suggested adding a notification mechanism to the namespace (mount) mechanism and do things at that level. It entails more kernel core hacking, but it would be cleaner in a whole lot of ways. I will look into it this evening.

-hpa

#9 lore raw
Quoted 11 lines · H. Peter Anvin
Quoted 5 lines · Ion Badulescu

Direct mounts would solve all these issues in a much more elegant way. We already have overlay mounts, we already have bind mounts, all the elements are in place to support direct mounts without much effort.

Yes, except for atomicity concerns. Anyway, I had a talk with Linus about this about an hour ago, and he suggested adding a notification mechanism to the namespace (mount) mechanism and do things at that level. It entails more kernel core hacking, but it would be cleaner in a whole lot of ways. I will look into it this evening.

If you cannot change the core 2.4 kernel, then maybe you'd consider a fist-lite based template as a starting point for v5. Although it takes over more ops than you may need, it is a fully standalone f/s that's reasonably stable and with <1% overhead.

BTW HPA, you do recall Ion's "how to design a good autofs that plays well with automounters" from some time ago, right? :-)

Quoted 1 line

-hpa

Erez.

#10 lore raw
Quoted 4 lines · Erez Zadok

BTW HPA, you do recall Ion's "how to design a good autofs that plays well with automounters" from some time ago, right? :-)

No, I don't believe I have seen it.

-hpa

#11 lore raw
In reply to Ion Badulescu
Quoted 10 lines · Ion Badulescu
Quoted 5 lines · Charles P. Wright

AFAIK, In FiST-lite what happens is the upper level (wrapfs) inode has its address space operations set to the operations of the lower level (e.g., EXT2) inode. A quick look at the code seemed to confirm this.

Quoted 6 lines

Hmm. You're probably right (you've been hacking that code more recently than I have...). Anyway, what I said initially was definitely the original approach for FiST-lite, and I guess my memory is getting fuzzy on recent details, even though I actively worked on them. :-)

From what I know about FiST, this is not quite true. The aops of wrapfs inode are not pointed to the lower level fs's aops. Most of the address space operations have a struct page, which a struct page have its mapping and host ref to inode. The lower level inode is ref by the wrapfs inode private data. The wrapgs has its own page cache and looks like a separate fs to the VFS in all aspects.

David

#12 lore raw
Quoted 14 lines · David Chow
Quoted 7 lines · Ion Badulescu
Quoted 5 lines · Charles P. Wright

AFAIK, In FiST-lite what happens is the upper level (wrapfs) inode has its address space operations set to the operations of the lower level (e.g., EXT2) inode. A quick look at the code seemed to confirm this.

Quoted 6 lines

Hmm. You're probably right (you've been hacking that code more recently than I have...). Anyway, what I said initially was definitely the original approach for FiST-lite, and I guess my memory is getting fuzzy on recent details, even though I actively worked on them. :-)

Quoted 6 lines

From what I know about FiST, this is not quite true. The aops of wrapfs
inode are not pointed to the lower level fs's aops. Most of the address space operations have a struct page, which a struct page have its mapping and host ref to inode. The lower level inode is ref by the wrapfs inode private data. The wrapgs has its own page cache and looks like a separate fs to the VFS in all aspects.

David,

We've recently improved the FiST code, such that if you specify filter data, this is indeed the case and a separate page cache is kept. However, if data is not filtered then FiST-lite is used (the method described above). This decreases performance overhead to about 1% over a native file system (compared to full-blown FiST which is about 5%).

Charles