Skip to contentSkip to conversation

memorder: Fix conflict of commandchars choice in .litmus files

PATCH New Akira Yokosawa 1 participant 1 message Jan 21, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 memorder: Fix conflict of commandchars choice in .litmus files

From aa363e5eb43bec50d5126be41314d10343397d9a Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <[email protected]>
Date: Tue, 22 Jan 2019 00:15:10 +0900
Subject: [PATCH] memorder: Fix conflict of commandchars choice in .litmus files

As "\" is used in the "exists" clause, commandchars should not contain it. "@" should be a safe choice for litmus tests.

---
Hi Paul,

This should recover vanished "\" in the exists clauses of the new snippets of RCU litmus tests.

To add the check of commandchars in fcvexclude.pl is on my to-do list. Or ideally the choice could be made automatic.

BTW, C-SB+o-rcusync-o+rl-o-rul-o.litmus and C-SB+o-rcusync-o+rl-rul-o.litmus looks identical, and causes warning of "duplicate targets" from "make". Can you please look into them?

Thanks, Akira
--

 CodeSamples/formal/herd/C-LB+o-rl-rul-o+o-rl-rul-o.litmus               | 2 +-
 CodeSamples/formal/herd/C-LB+rl-o-o-rul+rl-o-o-rul.litmus               | 2 +-
 CodeSamples/formal/herd/C-SB+o-rcusync-o+i-rl-o-o-rul.litmus            | 2 +-
 CodeSamples/formal/herd/C-SB+o-rcusync-o+o-o.litmus                     | 2 +-
 .../herd/C-SB+o-rcusync-o+o-rcusync-o+rl-o-o-rul+rl-o-o-rul.litmus      | 2 +-
 CodeSamples/formal/herd/C-SB+o-rcusync-o+o-rcusync-o.litmus             | 2 +-
 CodeSamples/formal/herd/C-SB+o-rcusync-o+o-rl-o-rul.litmus              | 2 +-
 CodeSamples/formal/herd/C-SB+o-rcusync-o+o-rl-rul-o.litmus              | 2 +-
 CodeSamples/formal/herd/C-SB+o-rcusync-o+rl-o-o-rul+rl-o-o-rul.litmus   | 2 +-
 CodeSamples/formal/herd/C-SB+o-rcusync-o+rl-o-o-rul.litmus              | 2 +-
 CodeSamples/formal/herd/C-SB+o-rcusync-o+rl-o-rul-o.litmus              | 2 +-
 CodeSamples/formal/herd/C-SB+o-rcusync-o+rl-rul-o.litmus                | 2 +-
 12 files changed, 12 insertions(+), 12 deletions(-)
CodeSamples/formal/herd/C-LB+o-rl-rul-o+o-rl-rul-o.litmus +1 -1
index 68ecdec..f53ffac 100644
@@ -1,5 +1,5 @@
 C C-LB+o-rl-rul-o+o-rl-rul-o
-//\begin[snippet][labelbase=ln:formal:C-LB+o-rl-rul-o+o-rl-rul-o:whole,commandchars=\\\[\]]
+//\begin[snippet][labelbase=ln:formal:C-LB+o-rl-rul-o+o-rl-rul-o:whole,commandchars=\@\[\]]
 {
 }
 
CodeSamples/formal/herd/C-LB+rl-o-o-rul+rl-o-o-rul.litmus +1 -1
index 8c53137..829e82d 100644
@@ -1,5 +1,5 @@
 C C-LB+rl-o-o-rul+rl-o-o-rul
-//\begin[snippet][labelbase=ln:formal:C-LB+rl-o-o-rul+rl-o-o-rul:whole,commandchars=\\\[\]]
+//\begin[snippet][labelbase=ln:formal:C-LB+rl-o-o-rul+rl-o-o-rul:whole,commandchars=\@\[\]]
 {
 }
 
CodeSamples/formal/herd/C-SB+o-rcusync-o+i-rl-o-o-rul.litmus +1 -1
index 1b3c394..2422abe 100644
@@ -1,5 +1,5 @@
 C C-SB+o-rcusync-o+i-rl-o-o-rul
-//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+i-rl-o-o-rul:whole,commandchars=\\\[\]]
+//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+i-rl-o-o-rul:whole,commandchars=\@\[\]]
 {
 }
 
CodeSamples/formal/herd/C-SB+o-rcusync-o+o-o.litmus +1 -1
index 1aef1ee..4c471c4 100644
@@ -1,5 +1,5 @@
 C C-SB+o-rcusync-o+o-o
-//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+o-o:whole,commandchars=\\\[\]]
+//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+o-o:whole,commandchars=\@\[\]]
 {
 }
 
CodeSamples/formal/herd/C-SB+o-rcusync-o+o-rcusync-o+rl-o-o-rul+rl-o-o-rul.litmus +1 -1
index a83d130..78eed5e 100644
@@ -1,5 +1,5 @@
 C C-SB+o-rcusync-o+o-rcusync-o+rl-o-o-rul+rl-o-o-rul
-//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+o-rcusync-o+rl-o-o-rul+rl-o-o-rul:whole,commandchars=\\\[\]]
+//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+o-rcusync-o+rl-o-o-rul+rl-o-o-rul:whole,commandchars=\@\[\]]
 {
 }
 
CodeSamples/formal/herd/C-SB+o-rcusync-o+o-rcusync-o.litmus +1 -1
index cd5a358..e43188b 100644
@@ -1,5 +1,5 @@
 C C-SB+o-rcusync-o+o-rcusync-o
-//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+o-rcusync-o:whole,commandchars=\\\[\]]
+//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+o-rcusync-o:whole,commandchars=\@\[\]]
 {
 }
 
CodeSamples/formal/herd/C-SB+o-rcusync-o+o-rl-o-rul.litmus +1 -1
index f6bcc25..a4e3aa9 100644
@@ -1,5 +1,5 @@
 C C-SB+o-rcusync-o+o-rl-o-rul
-//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+o-rl-o-rul:whole,commandchars=\\\[\]]
+//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+o-rl-o-rul:whole,commandchars=\@\[\]]
 {
 }
 
CodeSamples/formal/herd/C-SB+o-rcusync-o+o-rl-rul-o.litmus +1 -1
index 70b03ae..7998036 100644
@@ -1,5 +1,5 @@
 C C-SB+o-rcusync-o+o-rl-rul-o
-//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+o-rl-rul-o:whole,commandchars=\\\[\]]
+//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+o-rl-rul-o:whole,commandchars=\@\[\]]
 {
 }
 
CodeSamples/formal/herd/C-SB+o-rcusync-o+rl-o-o-rul+rl-o-o-rul.litmus +1 -1
index 7d13f3e..4905ea5 100644
@@ -1,5 +1,5 @@
 C C-SB+o-rcusync-o+rl-o-o-rul+rl-o-o-rul
-//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+rl-o-o-rul+rl-o-o-rul:whole,commandchars=\\\[\]]
+//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+rl-o-o-rul+rl-o-o-rul:whole,commandchars=\@\[\]]
 {
 }
 
CodeSamples/formal/herd/C-SB+o-rcusync-o+rl-o-o-rul.litmus +1 -1
index a3462f8..4be12dd 100644
@@ -1,5 +1,5 @@
 C C-SB+o-rcusync-o+rl-o-o-rul
-//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+rl-o-o-rul:whole,commandchars=\\\[\]]
+//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+rl-o-o-rul:whole,commandchars=\@\[\]]
 {
 }
 
CodeSamples/formal/herd/C-SB+o-rcusync-o+rl-o-rul-o.litmus +1 -1
index fa32853..356a61e 100644
@@ -1,5 +1,5 @@
 C C-SB+o-rcusync-o+rl-o-rul-o
-//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+rl-o-rul-o:whole,commandchars=\\\[\]]
+//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+rl-o-rul-o:whole,commandchars=\@\[\]]
 {
 }
 
CodeSamples/formal/herd/C-SB+o-rcusync-o+rl-rul-o.litmus +1 -1
index fa32853..356a61e 100644
@@ -1,5 +1,5 @@
 C C-SB+o-rcusync-o+rl-o-rul-o
-//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+rl-o-rul-o:whole,commandchars=\\\[\]]
+//\begin[snippet][labelbase=ln:formal:C-SB+o-rcusync-o+rl-o-rul-o:whole,commandchars=\@\[\]]
 {
 }
 
Signature · 1 line
2.7.4