Skip to contentSkip to conversation

Is the change to IDE probing really necessary?

DISCUSSION Bodo Eggert 1 participant 1 message Nov 26, 2008 7 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#7 lore raw
Quoted 2 lines · Alan Cox

So I think this is a case of 'I put best steam coal in my car and it didn't go'

"... but I was told it would."

I think less or different information (resulting in RTFM) might be more helpful. Looking at the 2.6.27 code, I'd

- change the default to -1 (unset) and let ide_generic_init print the text only if it's -1 (and then set it to the default value)
- change the text to
compiled_in? "please set ide_generic.probe_mask to use the generic IDE driver"
"please set probe_mask to probe for more legacy interfaces"
- not print anything if all interfaces are probed by default (non-x86)
- document "don't use this driver if there is a more specific driver" next to the probe_mask documentation