Skip to contentSkip to conversation

gpio: msic: Delete an error message in platform_msic_gpio_probe()

PATCH In review Markus Elfring 2 participants 2 messages Apr 4, 2020 – Apr 5, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: msic: Delete an error message in platform_msic_gpio_probe()

From: Markus Elfring <[email protected]>
Date: Sat, 4 Apr 2020 21:30:12 +0200

The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function.

This issue was detected by using the Coccinelle software.

---
 drivers/gpio/gpio-msic.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpio/gpio-msic.c +1 -3
index 7e3c96e4ab2c..5548b7be36b3 100644
@@ -248,10 +248,8 @@ static int platform_msic_gpio_probe(struct platform_device *pdev)
 	int retval;
 	int i;
 
-	if (irq < 0) {
-		dev_err(dev, "no IRQ line: %d\n", irq);
+	if (irq < 0)
 		return irq;
-	}
 
 	if (!pdata || !pdata->gpio_base) {
 		dev_err(dev, "incorrect or missing platform data\n");

--
2.26.0

#1 lore raw
Quoted 9 lines · Markus Elfring

From: Markus Elfring <[email protected]>
Date: Sat, 4 Apr 2020 21:30:12 +0200

The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function.

This issue was detected by using the Coccinelle software.

No need to touch this ancient driver, since it's subject to remove in one of the (nearest) future releases.

Signature · 2 lines
With Best Regards,
Andy Shevchenko