CVE-2016-7097 causes acl leak
Subsystems (2)
Commit 073931017b49d9458aa351605b43a7e34598caef has several occurrences of an acl leak.
posix_acl_update_mode(inose, &mode, &acl);
. . .
posix_acl_release(acl);
acl is NULLed in posix_acl_update_mode to signal caller to not update the acl; but because it is nulled, it is never released.
Sincerely -- Mark Salyzyn
Quoted 5 lines · Mark Salyzyn
Commit
073931017b49d9458aa351605b43a7e34598caefhas several occurrences of an acl leak.
posix_acl_update_mode(inose, &mode, &acl);
Quoted 7 lines
. . .
posix_acl_release(acl);acl is NULLed in
posix_acl_update_modeto signal caller to not update the acl; but because it is nulled, it is never released.
Any reason you didn't cc: the authors of that patch and the correct mailing list for it (hint, use scripts/get_maintainer.pl on the patch...)
Try that and see what happens...
thanks,
greg k-h
Quoted 5 lines · Mark Salyzyn
Commit
073931017b49d9458aa351605b43a7e34598caefhas several occurrences of an acl leak.
posix_acl_update_mode(inose, &mode, &acl);
Quoted 7 lines
. . .
posix_acl_release(acl);acl is NULLed in
posix_acl_update_modeto signal caller to not update the acl; but because it is nulled, it is never released.
I think you blame the wrong commit, this leak exists before that commit. Looks like we should just release it before NULL'ing.
fs/posix_acl.c +0 -0
@@ -648,8 +648,10 @@ int posix_acl_update_mode(struct inode *inode,
umode_t *mode_p,
error = posix_acl_equiv_mode(*acl, &mode);
if (error < 0)
return error;
- if (error == 0)
+ if (error == 0) {
+ posix_acl_release(*acl);
*acl = NULL;
+ }
if (!in_group_p(inode->i_gid) &&
!capable_wrt_inode_uidgid(inode, CAP_FSETID))
mode &= ~S_ISGID;Jan Kara
reviewerQuoted 8 lines · Cong Wang
Quoted 7 lines · Mark Salyzyn
Commit
073931017b49d9458aa351605b43a7e34598caefhas several occurrences of an acl leak.
posix_acl_update_mode(inose, &mode, &acl);. . .
Quoted 8 lines
Quoted 5 lines
posix_acl_release(acl);acl is NULLed in
posix_acl_update_modeto signal caller to not update the acl; but because it is nulled, it is never released.I think you blame the wrong commit, this leak exists before that commit. Looks like we should just release it before NULL'ing.
So I agree with you the mentioned commit didn't change anything. I took care to keep the previous behavior wrt NULLing the acl pointer (obviously I could have made mistake somewhere but I don't see where). However your patch is definitely wrong. See e.g. fs/ext2/acl.c: ext2_set_acl() - there we really want to just clear the pointer. We release the ACL in the caller of ext2_set_acl().
Mark why do you think we are leaking ACL references and can you be more specific where exactly it happens?
Honza
Quoted 17 lines
fs/posix_acl.c +3
-1@@ -648,8 +648,10 @@ int posix_acl_update_mode(struct inode *inode,umode_t *mode_p, error =posix_acl_equiv_mode (*acl, &mode);if (error <0 )return error; -if (error ==0 ) +if (error ==0 ) { +posix_acl_release (*acl); *acl =NULL ; + }if (!in_group_p (inode->i_gid) && !capable_wrt_inode_uidgid (inode,CAP_FSETID ))mode &= ~S_ISGID;
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 7 lines · Jan Kara
So I agree with you the mentioned commit didn't change anything. I took care to keep the previous behavior wrt NULLing the acl pointer (obviously I could have made mistake somewhere but I don't see where). However your patch is definitely wrong. See e.g.
fs/ext2/acl.c:ext2_set_acl()- there we really want to just clear the pointer. We release the ACL in the caller ofext2_set_acl().
Hmm, that is very subtle, are you saying we don't carry the change out of set_posix_acl() because we modify its argument on stack? This is clearly an anti-pattern in kernel code base.
Quoted 32 lines · Cong Wang
Quoted 5 lines · Mark Salyzyn
Commit
073931017b49d9458aa351605b43a7e34598caefhas several occurrences of an acl leak.
posix_acl_update_mode(inose, &mode, &acl);Quoted 7 lines
. . .
posix_acl_release(acl);acl is NULLed in
posix_acl_update_modeto signal caller to not update the acl; but because it is nulled, it is never released.I think you blame the wrong commit, this leak exists before that commit. Looks like we should just release it before NULL'ing.
fs/posix_acl.c +3
-1@@ -648,8 +648,10 @@ int posix_acl_update_mode(struct inode *inode,umode_t *mode_p, error =posix_acl_equiv_mode (*acl, &mode);if (error <0 )return error; -if (error ==0 ) +if (error ==0 ) { +posix_acl_release (*acl); *acl =NULL ; + }if (!in_group_p (inode->i_gid) && !capable_wrt_inode_uidgid (inode,CAP_FSETID ))
Quoted 1 line
mode &= ~S_ISGID;
The leaks were introduced in 9p, gfs2, jfs and xfs drivers only.
-- Mark
Quoted 2 lines · Mark Salyzyn
The leaks were introduced in 9p, gfs2, jfs and xfs drivers only.
Only the 9p case is obvious to me:
fs/9p/acl.c +0 -0
@@ -277,6 +277,7 @@ static int v9fs_xattr_set_acl(const struct
xattr_handler *handler,
case ACL_TYPE_ACCESS:
if (acl) {
struct iattr iattr;+ struct posix_acl *old_acl = acl;
retval = posix_acl_update_mode(inode,
&iattr.ia_mode, &acl);
if (retval)
@@ -287,6 +288,7 @@ static int v9fs_xattr_set_acl(const struct xattr_handler *handler,
* by the mode bits. So don't
* update ACL.
*/
+ posix_acl_release(old_acl);
value = NULL;
size = 0;
}The rest are anti-pattern (modifying parameters on stack via address) but look correct.
Jan Kara
reviewerQuoted 6 lines · Cong Wang
Quoted 2 lines · Mark Salyzyn
The leaks were introduced in 9p, gfs2, jfs and xfs drivers only.
Only the 9p case is obvious to me:
Agreed and the patch below looks good to me. Please make it a proper patch (including changelog, sign-off, etc.) and feel free to add my Reviewed-by tag.
Quoted 25 lines
fs/9p/acl.c +1
-0@@ -277,6 +277,7 @@ static int v9fs_xattr_set_acl(const struct xattr_handler *handler, case ACL_TYPE_ACCESS: if (acl) {struct iattr iattr; +struct posix_acl *old_acl = acl; retval = posix_acl_update_mode(inode,&iattr.ia_mode, &acl);
if (retval)fs/9p/acl.c +1
-0@@ -287,6 +288,7 @@ static int v9fs_xattr_set_acl(const structxattr_handler *handler, * by the mode bits. So don't * update ACL. */ +posix_acl_release (old_acl); value =NULL ; size =0 ;}
Quoted 2 lines
The rest are anti-pattern (modifying parameters on stack via address) but look correct.
I'm not sure what's so unusual about passing a pointer to a local variable (in fact a function argument but they are no different in C) to another function. I agree it is not the most straightforward code but it is not that complicated either...
What is important is that a function that acquires a reference to an acl also releases that reference. That is a common pattern. I.e. we don't pass "a reference to an object", we just pass "a pointer to an object" to a function and guarantee the pointer will stay valid while the function runs. What does some function (in our case ->set_acl handler) do with the pointer you passed it is it's internal bussiness.
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 11 lines · Jan Kara
Quoted 6 lines · Cong Wang
Quoted 2 lines · Mark Salyzyn
The leaks were introduced in 9p, gfs2, jfs and xfs drivers only.
Only the 9p case is obvious to me:
Agreed and the patch below looks good to me. Please make it a proper patch (including changelog, sign-off, etc.) and feel free to add my Reviewed-by tag.
Done.
Quoted 7 lines
Quoted 2 lines
The rest are anti-pattern (modifying parameters on stack via address) but look correct.
I'm not sure what's so unusual about passing a pointer to a local variable (in fact a function argument but they are no different in C) to another function. I agree it is not the most straightforward code but it is not that complicated either...
Function arguments technically belong to caller's context, while local variables belong to callee's. I have never seen such a use case in kernel code base, this is why I think it is anti-pattern.
Quoted 8 lines
What is important is that a function that acquires a reference to an acl also releases that reference. That is a common pattern. I.e. we don't pass "a reference to an object", we just pass "a pointer to an object" to a function and guarantee the pointer will stay valid while the function runs. What does some function (in our case ->set_acl handler) do with the pointer you passed it is it's internal bussiness.
But passing a pointer to a pointer usually indicates we need to save the pointer,
in this case we actually don't, it is discarded as soon as the caller returns.
Thanks.
Quoted 30 lines · Cong Wang
Quoted 1 line · Mark Salyzyn
The leaks were introduced in 9p, gfs2, jfs and xfs drivers only.
Only the 9p case is obvious to me:
fs/9p/acl.c +1
-0@@ -277,6 +277,7 @@ static int v9fs_xattr_set_acl(const struct xattr_handler *handler, case ACL_TYPE_ACCESS: if (acl) {struct iattr iattr; +struct posix_acl *old_acl = acl; retval = posix_acl_update_mode(inode,&iattr.ia_mode, &acl);
if (retval)fs/9p/acl.c +1
-0@@ -287,6 +288,7 @@ static int v9fs_xattr_set_acl(const structxattr_handler *handler, * by the mode bits. So don't * update ACL. */ +posix_acl_release (old_acl); value =NULL ; size =0 ;}
Quoted 2 lines
The rest are anti-pattern (modifying parameters on stack via address) but look correct
I chose to modify posix_acl_update_mode as follows and set release_acl in the specific drivers, it clears the *acl reference to nul preventing posix_acl_release from functioning in these other driver paths:
*/
int posix_acl_update_mode(struct inode *inode, umode_t *mode_p,
struct posix_acl **acl, ++++bool release_acl)
{
umode_t mode = inode->i_mode;
int error;
error = posix_acl_equiv_mode(*acl, &mode);
if (error < 0)
return error;
if (error == 0) +{
+ if (release_acl)
+ posix_acl_release(*acl);
*acl = NULL;
+ }
if (!in_group_p(inode->i_gid) &&
!capable_wrt_inode_uidgid(inode, CAP_FSETID))
mode &= ~S_ISGID;
*mode_p = mode;
return 0;
}EXPORT_SYMBOL(posix_acl_update_mode);
Jan Kara
reviewerQuoted 57 lines · Mark Salyzyn
Quoted 30 lines · Cong Wang
Quoted 1 line · Mark Salyzyn
The leaks were introduced in 9p, gfs2, jfs and xfs drivers only.
Only the 9p case is obvious to me:
fs/9p/acl.c +1
-0@@ -277,6 +277,7 @@ static int v9fs_xattr_set_acl(const struct xattr_handler *handler, case ACL_TYPE_ACCESS: if (acl) {struct iattr iattr; +struct posix_acl *old_acl = acl; retval = posix_acl_update_mode(inode,&iattr.ia_mode, &acl);
if (retval)fs/9p/acl.c +1
-0@@ -287,6 +288,7 @@ static int v9fs_xattr_set_acl(const structxattr_handler *handler, * by the mode bits. So don't * update ACL. */ +posix_acl_release (old_acl); value =NULL ; size =0 ;}Quoted 2 lines
The rest are anti-pattern (modifying parameters on stack via address) but look correct
I chose to modify
posix_acl_update_modeas follows and setrelease_aclin the specific drivers, it clears the *acl reference to nul preventingposix_acl_releasefrom functioning in these other driver paths:*/
int posix_acl_update_mode(struct inode *inode,umode_t*mode_p,
structposix_acl**acl, ++++boolrelease_acl){ umode_t mode = inode->i_mode; int error; error = posix_acl_equiv_mode(*acl, &mode); if (error < 0) return error; if (error == 0) +{(quoted diff) +3
-0+ if (release_acl) + posix_acl_release(*acl); *acl = NULL; + } if (!in_group_p(inode->i_gid) && !capable_wrt_inode_uidgid(inode, CAP_FSETID)) mode &= ~S_ISGID; *mode_p = mode; return 0;
Quoted 2 lines
}
EXPORT_SYMBOL(posix_acl_update_mode);
I much prefer what Cong Wang did. These bool parameters which subtly change the function behavior are too easy to screw up and it is not really visible by just looking at the function call...
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 30 lines · Cong Wang
Quoted 1 line · Mark Salyzyn
The leaks were introduced in 9p, gfs2, jfs and xfs drivers only.
Only the 9p case is obvious to me:
fs/9p/acl.c +1
-0@@ -277,6 +277,7 @@ static int v9fs_xattr_set_acl(const struct xattr_handler *handler, case ACL_TYPE_ACCESS: if (acl) {struct iattr iattr; +struct posix_acl *old_acl = acl; retval = posix_acl_update_mode(inode,&iattr.ia_mode, &acl);
if (retval)fs/9p/acl.c +1
-0@@ -287,6 +288,7 @@ static int v9fs_xattr_set_acl(const structxattr_handler *handler, * by the mode bits. So don't * update ACL. */ +posix_acl_release (old_acl); value =NULL ; size =0 ;}
Quoted 2 lines
The rest are anti-pattern (modifying parameters on stack via address) but look correct.
Greg KH: Beware that this similar fix needs to be applied to _backports_ to stable kernel trees on other filesystem driver that have the same pattern (with local posix_acl_release(acl) calls). I have found that depending on vintage these would include this driver 9p, and possibly gfs2, jfs and xfs. Be aware.
Sincerely -- Mark Salyzyn
Quoted 31 lines · Mark Salyzyn
Quoted 30 lines · Cong Wang
Quoted 1 line · Mark Salyzyn
The leaks were introduced in 9p, gfs2, jfs and xfs drivers only.
Only the 9p case is obvious to me:
fs/9p/acl.c +1
-0@@ -277,6 +277,7 @@ static int v9fs_xattr_set_acl(const struct xattr_handler *handler, case ACL_TYPE_ACCESS: if (acl) {struct iattr iattr; +struct posix_acl *old_acl = acl; retval = posix_acl_update_mode(inode,&iattr.ia_mode, &acl);
if (retval)fs/9p/acl.c +1
-0@@ -287,6 +288,7 @@ static int v9fs_xattr_set_acl(const structxattr_handler *handler, * by the mode bits. So don't * update ACL. */ +posix_acl_release (old_acl); value =NULL ; size =0 ;}
Quoted 8 lines
Quoted 2 lines
The rest are anti-pattern (modifying parameters on stack via address) but look correct.
Greg KH: Beware that this similar fix needs to be applied to _backports_ to stable kernel trees on other filesystem driver that have the same pattern (with local
posix_acl_release(acl)calls). I have found that depending on vintage these would include this driver 9p, and possibly gfs2, jfs and xfs. Be aware.
I don't understand what you mean here. What needs to be "backported" to the stable tree? What commit in Linus's tree do I pick? If not a commit there, where is it?
totally confused,
greg k-h
Quoted 38 lines · Greg KH
Quoted 30 lines · Mark Salyzyn
Quoted 29 lines · Cong Wang
Quoted 1 line · Mark Salyzyn
The leaks were introduced in 9p, gfs2, jfs and xfs drivers only.
Only the 9p case is obvious to me:
fs/9p/acl.c +1
-0@@ -277,6 +277,7 @@ static int v9fs_xattr_set_acl(const struct xattr_handler *handler, case ACL_TYPE_ACCESS: if (acl) {struct iattr iattr; +struct posix_acl *old_acl = acl; retval = posix_acl_update_mode(inode,&iattr.ia_mode, &acl);
if (retval)fs/9p/acl.c +1
-0@@ -287,6 +288,7 @@ static int v9fs_xattr_set_acl(const structxattr_handler *handler, * by the mode bits. So don't * update ACL. */ +posix_acl_release (old_acl); value =NULL ; size =0 ;}Quoted 7 lines
Quoted 2 lines
The rest are anti-pattern (modifying parameters on stack via address) but look correct.
Greg KH: Beware that this similar fix needs to be applied to _backports_ to stable kernel trees on other filesystem driver that have the same pattern (with local
posix_acl_release(acl)calls). I have found that depending on vintage these would include this driver 9p, and possibly gfs2, jfs and xfs. Be aware.
Quoted 7 lines
I don't understand what you mean here. What needs to be "backported" to the stable tree? What commit in Linus's tree do I pick? If not a commit there, where is it?
totally confused,
greg k-h
In 3.10-stable if you took the original CVE-2016-7097 fix it could break four file system drivers, the fix for each would 'look like' this one fix for the 9p driver.
-- Mark
Quoted 43 lines · Mark Salyzyn
Quoted 42 lines · Greg KH
Quoted 30 lines · Mark Salyzyn
Quoted 29 lines · Cong Wang
Quoted 1 line · Mark Salyzyn
The leaks were introduced in 9p, gfs2, jfs and xfs drivers only.
Only the 9p case is obvious to me:
fs/9p/acl.c +1
-0@@ -277,6 +277,7 @@ static int v9fs_xattr_set_acl(const struct xattr_handler *handler, case ACL_TYPE_ACCESS: if (acl) {struct iattr iattr; +struct posix_acl *old_acl = acl; retval = posix_acl_update_mode(inode,&iattr.ia_mode, &acl);
if (retval)fs/9p/acl.c +1
-0@@ -287,6 +288,7 @@ static int v9fs_xattr_set_acl(const structxattr_handler *handler, * by the mode bits. So don't * update ACL. */ +posix_acl_release (old_acl); value =NULL ; size =0 ;}Quoted 7 lines
Quoted 2 lines
The rest are anti-pattern (modifying parameters on stack via address) but look correct.
Greg KH: Beware that this similar fix needs to be applied to _backports_ to stable kernel trees on other filesystem driver that have the same pattern (with local
posix_acl_release(acl)calls). I have found that depending on vintage these would include this driver 9p, and possibly gfs2, jfs and xfs. Be aware.I don't understand what you mean here. What needs to be "backported" to the stable tree? What commit in Linus's tree do I pick? If not a commit there, where is it?
Quoted 7 lines
Quoted 3 lines
totally confused,
greg k-h
In 3.10-stable if you took the original CVE-2016-7097 fix it could break four file system drivers, the fix for each would 'look like' this one fix for the 9p driver.
Did I take the fix in 3.10-stable? What was the git commit id? Is 3.10 "broken" in this way? Is any other stable kernel broken?
I still don't have any idea of what is going on here...
greg k-h
Quoted 50 lines · Greg KH
Quoted 43 lines · Mark Salyzyn
Quoted 42 lines · Greg KH
Quoted 30 lines · Mark Salyzyn
Quoted 29 lines · Cong Wang
Quoted 1 line · Mark Salyzyn
The leaks were introduced in 9p, gfs2, jfs and xfs drivers only.
Only the 9p case is obvious to me:
fs/9p/acl.c +1
-0@@ -277,6 +277,7 @@ static int v9fs_xattr_set_acl(const struct xattr_handler *handler, case ACL_TYPE_ACCESS: if (acl) {struct iattr iattr; +struct posix_acl *old_acl = acl; retval = posix_acl_update_mode(inode,&iattr.ia_mode, &acl);
if (retval)fs/9p/acl.c +1
-0@@ -287,6 +288,7 @@ static int v9fs_xattr_set_acl(const structxattr_handler *handler, * by the mode bits. So don't * update ACL. */ +posix_acl_release (old_acl); value =NULL ; size =0 ;}Quoted 7 lines
Quoted 2 lines
The rest are anti-pattern (modifying parameters on stack via address) but look correct.
Greg KH: Beware that this similar fix needs to be applied to _backports_ to stable kernel trees on other filesystem driver that have the same pattern (with local
posix_acl_release(acl)calls). I have found that depending on vintage these would include this driver 9p, and possibly gfs2, jfs and xfs. Be aware.I don't understand what you mean here. What needs to be "backported" to the stable tree? What commit in Linus's tree do I pick? If not a commit there, where is it?
Quoted 6 lines
Quoted 3 lines
totally confused,
greg k-h
In 3.10-stable if you took the original CVE-2016-7097 fix it could break four file system drivers, the fix for each would 'look like' this one fix for the 9p driver.
Quoted 6 lines
Did I take the fix in 3.10-stable? What was the git commit id? Is 3.10 "broken" in this way? Is any other stable kernel broken?
I still don't have any idea of what is going on here...
greg k-h
Nothing is going on here, it is a heads up, eventually CVE's get backported to stable as we do take them in through those paths. Telling you to be aware that the original commit causes a leak, and my experience has found that the leak affects these four file system drivers.
-- Mark
Jan Kara
reviewerQuoted 54 lines · Mark Salyzyn
Quoted 53 lines · Greg KH
Quoted 43 lines · Mark Salyzyn
Quoted 42 lines · Greg KH
Quoted 30 lines · Mark Salyzyn
Quoted 29 lines · Cong Wang
Quoted 1 line · Mark Salyzyn
The leaks were introduced in 9p, gfs2, jfs and xfs drivers only.
Only the 9p case is obvious to me:
fs/9p/acl.c +1
-0@@ -277,6 +277,7 @@ static int v9fs_xattr_set_acl(const struct xattr_handler *handler, case ACL_TYPE_ACCESS: if (acl) {struct iattr iattr; +struct posix_acl *old_acl = acl; retval = posix_acl_update_mode(inode,&iattr.ia_mode, &acl);
if (retval)fs/9p/acl.c +1
-0@@ -287,6 +288,7 @@ static int v9fs_xattr_set_acl(const structxattr_handler *handler, * by the mode bits. So don't * update ACL. */ +posix_acl_release (old_acl); value =NULL ; size =0 ;}Quoted 7 lines
Quoted 2 lines
The rest are anti-pattern (modifying parameters on stack via address) but look correct.
Greg KH: Beware that this similar fix needs to be applied to _backports_ to stable kernel trees on other filesystem driver that have the same pattern (with local
posix_acl_release(acl)calls). I have found that depending on vintage these would include this driver 9p, and possibly gfs2, jfs and xfs. Be aware.I don't understand what you mean here. What needs to be "backported" to the stable tree? What commit in Linus's tree do I pick? If not a commit there, where is it?
Quoted 6 lines
Quoted 3 lines
totally confused,
greg k-h
In 3.10-stable if you took the original CVE-2016-7097 fix it could break four file system drivers, the fix for each would 'look like' this one fix for the 9p driver.
Did I take the fix in 3.10-stable? What was the git commit id? Is 3.10 "broken" in this way? Is any other stable kernel broken?
Quoted 8 lines
Quoted 3 lines
I still don't have any idea of what is going on here...
greg k-h
Nothing is going on here, it is a heads up, eventually CVE's get backported to stable as we do take them in through those paths. Telling you to be aware that the original commit causes a leak, and my experience has found that the leak affects these four file system drivers.
Original commit (073931017b49) fixing the CVE does not contain the leak. The leak in 9p was there before that commit. But yes, a naive backport of that commit into 3.10 will introduce new similar leaks into xfs and others.
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Jan Kara
reviewerQuoted 28 lines · Mark Salyzyn
Quoted 27 lines · Cong Wang
Quoted 5 lines · Mark Salyzyn
Commit
073931017b49d9458aa351605b43a7e34598caefhas several occurrences of an acl leak.
posix_acl_update_mode(inose, &mode, &acl);Quoted 7 lines
. . .
posix_acl_release(acl);acl is NULLed in
posix_acl_update_modeto signal caller to not update the acl; but because it is nulled, it is never released.I think you blame the wrong commit, this leak exists before that commit. Looks like we should just release it before NULL'ing.
fs/posix_acl.c +1
-1@@ -648,8 +648,10 @@ int posix_acl_update_mode(struct inode *inode,umode_t *mode_p, error =posix_acl_equiv_mode (*acl, &mode);if (error <0 )return error; -if (error ==0 ) +if (error ==0 ) {
Quoted 8 lines
Quoted 6 lines
fs/posix_acl.c +2
-0+posix_acl_release (*acl); *acl =NULL ; + }if (!in_group_p (inode->i_gid) && !capable_wrt_inode_uidgid (inode,CAP_FSETID ))mode &= ~S_ISGID;The leaks were introduced in 9p, gfs2, jfs and xfs drivers only.
So I agree 9p leaks acl reference (and it was buggy even before my commit). GFS2, JFS, and XFS seem to be OK as far as I can tell.
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR