Skip to contentSkip to conversation

Revert "RDMA/core: Fix ENODEV error for iWARP test over vlan"

PATCH Applied Leon Romanovsky 1 participant 2 messages Nov 12, 2024 InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "RDMA/core: Fix ENODEV error for iWARP test over vlan"

From: Leon Romanovsky <[email protected]>

The citied commit in Fixes line caused to regression for udaddy [1] application. It doesn't work over VLANs anymore.

Client:
ifconfig eth2 1.1.1.1
ip link add link eth2 name p0.3597 type vlan protocol 802.1Q id 3597 ip link set dev p0.3597 up
ip addr add 2.2.2.2/16 dev p0.3597
udaddy -S 847 -C 220 -c 2 -t 0 -s 2.2.2.3 -b 2.2.2.2

Server:
ifconfig eth2 1.1.1.3
ip link add link eth2 name p0.3597 type vlan protocol 802.1Q id 3597 ip link set dev p0.3597 up
ip addr add 2.2.2.3/16 dev p0.3597
udaddy -S 847 -C 220 -c 2 -t 0 -b 2.2.2.3

[1] https://github.com/linux-rdma/rdma-core/blob/master/librdmacm/examples/udaddy.c

Fixes 5069d7e202f6 ("RDMA/core: Fix ENODEV error for iWARP test over vlan")
---
 drivers/infiniband/core/addr.c | 2 --
 1 file changed, 2 deletions(-)
drivers/infiniband/core/addr.c +0 -2
index c4cf26f1d149..be0743dac3ff 100644
@@ -269,8 +269,6 @@ rdma_find_ndev_for_src_ip_rcu(struct net *net, const struct sockaddr *src_in)
 		break;
 #endif
 	}
-	if (!ret && dev && is_vlan_dev(dev))
-		dev = vlan_dev_real_dev(dev);
 	return ret ? ERR_PTR(ret) : dev;
 }
 
Signature · 1 line
2.47.0
author Applied
#1 lore raw
Quoted 11 lines · Leon Romanovsky

The citied commit in Fixes line caused to regression for udaddy [1] application. It doesn't work over VLANs anymore.

Client:
ifconfig eth2 1.1.1.1
ip link add link eth2 name p0.3597 type vlan protocol 802.1Q id 3597 ip link set dev p0.3597 up
ip addr add 2.2.2.2/16 dev p0.3597
udaddy -S 847 -C 220 -c 2 -t 0 -s 2.2.2.3 -b 2.2.2.2

[...]

Applied, thanks!

[1/1] Revert "RDMA/core: Fix ENODEV error for iWARP test over vlan"

      https://git.kernel.org/rdma/rdma/c/6abe2a90808192

Best regards,

Signature · 1 line
Leon Romanovsky <[email protected]>