Skip to contentSkip to conversation

KVM: nVMX: Fix some comment typos and coding style

PATCH linmiaohe 1 participant 1 message Feb 7, 2020 KVM

lore
Share & tools
lore

linmiaohe

author
#0 lore raw

Hi:

Quoted 12 lines · Sean Christopherson
Quoted 6 lines · Vitaly Kuznetsov

linmiaohe <[email protected]> writes:

I have to admit that shadow MMU in KVM is not my strong side but this comment reads weird, I'd appreciate if someone could suggest a better alternative.

	/* One off flag for a stupid corner case in shadow paging. */
Quoted 2 lines
Quoted 2 lines

*/

Quoted 16 lines

/*
* Indicates the guest is trying to write a gfn that contains one or
* more of the PTEs used to translate the write itself, i.e. the access
* is changing its own translation in the guest page tables. KVM exits
* to userspace if emulation of the faulting instruction fails and this
* flag is set, as KVM cannot make forward progress.
*
* If emulation fails for a write to guest page tables, KVM unprotects
* (zaps) the shadow page for the target gfn and resumes the guest to
* retry the non-emulatable instruction (on hardware). Unprotecting the
* gfn doesn't allow forward progress for a self-changing access because
* doing so also zaps the translation for the gfn, i.e. retrying the
* instruction will hit a !PRESENT fault, which results in a new shadow
* page and sends KVM back to square one.
*/

Quoted 1 line
Quoted 1 line

bool write_fault_to_shadow_pgtable;

Thanks for your detail comment. This field confused me once.

Thanks to both for review! Will send v2.