Skip to contentSkip to conversation

vfs: added better file aio_read aio_write operations presence check

PATCH Bodo Eggert 2 participants 2 messages Sep 16, 2008 2 messages not in the archive VFS

lore
Share & tools
lore
#2 lore raw
In reply to a message not in the archive
Quoted 16 lines · Manish Katiyar

On Tue, Sep 16, 2008 at 2:59 PM, Marco Stornelli

Quoted 9 lines

From: Marco Stornelli <[email protected]>

If a filesystem in the file operations specifies for read and write operations only do_sync_read and do_sync_write without init aio_read and aio_write, there will be a kernel oops, because the vfs code check the presence of (to read for example) read OR aio_read method, then it calls read if it's pointer is not null. It's not sufficient because if the read function is actually a do_sync_read, it calls aio_read but without checking the presence. I think a BUG_ON check can be more useful.

Instead of doing a BUG_ON() why can't we simply fall back to the generic_aio functions since most of the fs tend to do so as below.

--- a/fs/read_write.c

Review

Quoted 5 lines
(quoted diff) +4 -1
-             ret = filp->f_op->aio_read(&kiocb, &iov, 1, kiocb.ki_pos);
+             if (filp->f_op->aio_read)
+                     ret = filp->f_op->aio_read(&kiocb, &iov, 1, kiocb.ki_pos);
+             else
+                     ret = generic_file_aio_read(&kiocb, &iov, 1, kiocb.ki_pos);

Why can't the file system registration code set filp->f_op->aio_read to generic_file_aio_read?

#3 lore raw
Quoted 2 lines · Bodo Eggert

Why can't the file system registration code set filp->f_op->aio_read to generic_file_aio_read?

        const struct file_operations    *f_op;

Having said that, BUILD_BUG_ON(!f_op->aio_read) is fine by me ... make the filesystem writer put it in without slowing down anyone at runtime.

Signature · 4 lines
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."