Skip to contentSkip to conversation

x86/MTRR: correct inadvertently inverted WC check

PATCH In review Jan Beulich 2 participants 2 messages Apr 23, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/MTRR: correct inadvertently inverted WC check

The ! clearly got lost by mistake.

Fixes e9e0eb30d4d6 ("x86/MTRR: avoid several indirect calls")
xen/arch/x86/cpu/mtrr/main.c +1 -1
@@ -316,7 +316,7 @@ int mtrr_add_page(unsigned long base, un
 	}
 
 	/*  If the type is WC, check that this processor supports it  */
-	if ((type == X86_MT_WC) && mtrr_have_wrcomb()) {
+	if ((type == X86_MT_WC) && !mtrr_have_wrcomb()) {
 		printk(KERN_WARNING
 		       "mtrr: your processor doesn't support write-combining\n");
 		return -EOPNOTSUPP;