Skip to contentSkip to conversation

EDAC driver for DMC520

DISCUSSION Scott Branden 3 participants 8 messages Jan 7, 2020

lore
Share & tools
lore
#1 lore raw
Quoted 5 lines · Scott Branden

Hello EDAC Maintainers,

Could somebody have a look at the DMC520 patch series that has been waiting for a response since November:
https://patchwork.kernel.org/patch/11248785/

Well, the dt bindings stuff is still being discussed:

https://patchwork.kernel.org/patch/11248783/

Also, looking at this again, the patch authorship looks really fishy:

Sender is

From: Shiping Ji <[email protected]>

however, he doesn't have his SOB in there and previous iterations were done with Lei Wang whose SOB *is* there so I dunno what's going on.

*Especially* if Lei Wang is being added as a maintainer of that driver by the second patch but he's not sending this driver himself. If this driver is going to be orphaned the moment it lands upstream, I'm not going to take it.

So at least those two things need to be fixed/clarified first.

HTH.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
#2 lore raw

Lei/Shiping,

Quoted 16 lines · Borislav Petkov
Quoted 5 lines · Scott Branden

Hello EDAC Maintainers,

Could somebody have a look at the DMC520 patch series that has been waiting for a response since November:
https://patchwork.kernel.org/patch/11248785/

Well, the dt bindings stuff is still being discussed:

https://patchwork.kernel.org/patch/11248783/

Also, looking at this again, the patch authorship looks really fishy:

Sender is

From: Shiping Ji <[email protected]>

Quoted 7 lines

however, he doesn't have his SOB in there and previous iterations were done with Lei Wang whose SOB *is* there so I dunno what's going on.

*Especially* if Lei Wang is being added as a maintainer of that driver by the second patch but he's not sending this driver himself. If this driver is going to be orphaned the moment it lands upstream, I'm not going to take it.

Shiping/Lei could you please provide appropriate signed-off-by? Also, if you do not have an appropriate maintainer for the driver we have Yuqing Shen who can be maintainer of this driver.

Quoted 5 lines

So at least those two things need to be fixed/clarified first.

HTH.

#3 lore raw
Quoted 22 lines · Scott Branden

Lei/Shiping,

Quoted 19 lines · Borislav Petkov
Quoted 5 lines · Scott Branden

Hello EDAC Maintainers,

Could somebody have a look at the DMC520 patch series that has been waiting for a response since November:
https://patchwork.kernel.org/patch/11248785/

Well, the dt bindings stuff is still being discussed:

https://patchwork.kernel.org/patch/11248783/

Also, looking at this again, the patch authorship looks really fishy:

Sender is

From: Shiping Ji <[email protected]>

however, he doesn't have his SOB in there and previous iterations were done with Lei Wang whose SOB *is* there so I dunno what's going on.

Quoted 7 lines
Quoted 4 lines

*Especially* if Lei Wang is being added as a maintainer of that driver by the second patch but he's not sending this driver himself. If this driver is going to be orphaned the moment it lands upstream, I'm not going to take it.

Shiping/Lei could you please provide appropriate signed-off-by? Also, if you do not have an appropriate maintainer for the driver we have Yuqing Shen who can be maintainer of this driver.

Yes, signed-off-by is still Lei Wang, who is still the official maintainer of the driver.

Lei is currently in sick leave so I'm trying to complete the patches on her behalf. Please kindly let me know how to add my SOB there.

Thanks!

Quoted 5 lines
Quoted 4 lines

So at least those two things need to be fixed/clarified first.

HTH.

Signature · 2 lines
Best regards,
Shiping Ji
#4 lore raw

Hi Shiping,

Quoted 5 lines · Shiping Ji
Quoted 4 lines · Scott Branden

Lei/Shiping,

Quoted 1 line · Borislav Petkov

On Tue, Jan 07, 2020 at 09:57:26AM -0800, Scott Branden wrote:

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines

Hello EDAC Maintainers,

Could somebody have a look at the DMC520 patch series that has been waiting for a response since November:
https://patchwork.kernel.org/patch/11248785/

Well, the dt bindings stuff is still being discussed:

https://patchwork.kernel.org/patch/11248783/

Shiping, you also need to address the binding comment here.

Quoted 14 lines
Quoted 14 lines
Quoted 14 lines

Also, looking at this again, the patch authorship looks really fishy:

Sender is

From: Shiping Ji <[email protected]>

however, he doesn't have his SOB in there and previous iterations were done with Lei Wang whose SOB *is* there so I dunno what's going on.

*Especially* if Lei Wang is being added as a maintainer of that driver by the second patch but he's not sending this driver himself. If this driver is going to be orphaned the moment it lands upstream, I'm not going to take it.

Quoted 6 lines
Quoted 3 lines

Shiping/Lei could you please provide appropriate signed-off-by? Also, if you do not have an appropriate maintainer for the driver we have Yuqing Shen who can be maintainer of this driver.

Yes, signed-off-by is still Lei Wang, who is still the official maintainer of the driver.

Lei is currently in sick leave so I'm trying to complete the patches on her behalf. Please kindly let me know how to add my SOB there.

If Lei is coming back soon then it may be best to wait for her?

Either way, I highly suggest you read the kernel documentation on submitting patches in the source tree:
Documentation/process/submitting-patches.rst.

Also, some of your other coworkers must know how to upstream code and can help you follow the process?

Quoted 6 lines

Thanks!

Quoted 4 lines
Quoted 4 lines

So at least those two things need to be fixed/clarified first.

HTH.

#5 lore raw

Hi Scott,

Quoted 10 lines · Scott Branden

Hi Shiping,

Quoted 7 lines · Shiping Ji
Quoted 6 lines · Scott Branden

Lei/Shiping,

Quoted 3 lines · Borislav Petkov
Quoted 2 lines · Scott Branden

Hello EDAC Maintainers,

Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines

Could somebody have a look at the DMC520 patch series that has been waiting for a response since November:
https://patchwork.kernel.org/patch/11248785/

Well, the dt bindings stuff is still being discussed:

https://patchwork.kernel.org/patch/11248783/

Shiping, you also need to address the binding comment here.

Yes, I'm currently working on the dt-binding changes.

Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines

Also, looking at this again, the patch authorship looks really fishy:

Sender is

From: Shiping Ji <[email protected]>

however, he doesn't have his SOB in there and previous iterations were done with Lei Wang whose SOB *is* there so I dunno what's going on.

*Especially* if Lei Wang is being added as a maintainer of that driver by the second patch but he's not sending this driver himself. If this driver is going to be orphaned the moment it lands upstream, I'm not going to take it.

Quoted 7 lines
Quoted 6 lines
Quoted 3 lines

Shiping/Lei could you please provide appropriate signed-off-by? Also, if you do not have an appropriate maintainer for the driver we have Yuqing Shen who can be maintainer of this driver.

Yes, signed-off-by is still Lei Wang, who is still the official maintainer of the driver.

Lei is currently in sick leave so I'm trying to complete the patches on her behalf. Please kindly let me know how to add my SOB there.

If Lei is coming back soon then it may be best to wait for her?

It may take another couple of months for her to return, we'd like to complete the current patches since these have been active for quite long time (almost one year).

Quoted 4 lines

Either way, I highly suggest you read the kernel documentation on submitting patches in the source tree:
Documentation/process/submitting-patches.rst.

Also, some of your other coworkers must know how to upstream code and can help you follow the process?

Yes, I followed the notes but apparently have missed some important steps. I'll go the above document and get it fixed.

The new patches are expected in a couple of days.

Quoted 7 lines
Quoted 6 lines

Thanks!

Quoted 4 lines
Quoted 4 lines

So at least those two things need to be fixed/clarified first.

HTH.

Signature · 2 lines
Best regards,
Shiping Ji
#6 lore raw
Quoted 1 line · Shiping Ji
Quoted 1 line

If Lei is coming back soon then it may be best to wait for her?

Whoops, I made her a "he". Lei, sorry about that.

You add your SOB under the original author's one:

From: Lei Wang <[email protected]>

<commit message>

Signed-off-by you

The kernel tree is full of examples. git log is your friend.

Quoted 2 lines

Yes, I followed the notes but apparently have missed some important steps. I'll go the above document and get it fixed.

Yes, it would be time well spent if you intend to deal with submitting patches to the kernel in the future.

Thx.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
#7 lore raw
Quoted 14 lines · Borislav Petkov
Quoted 1 line · Shiping Ji
Quoted 1 line

If Lei is coming back soon then it may be best to wait for her?

Whoops, I made her a "he". Lei, sorry about that.

You add your SOB under the original author's one:

From: Lei Wang <[email protected]>

<commit message>

Signed-off-by you
Quoted 9 lines

The kernel tree is full of examples. git log is your friend.

Quoted 2 lines

Yes, I followed the notes but apparently have missed some important steps. I'll go the above document and get it fixed.

Yes, it would be time well spent if you intend to deal with submitting patches to the kernel in the future.

Thx.

Thanks Boris for the clear instructions! I went through the document and understood the rationale of SOB now. I'll add mine in my next patches.

Signature · 2 lines
Best regards,
Shiping Ji