Skip to contentSkip to conversation

io_uring/cmd_net: use READ_ONCE() for ->addr3 read

PATCH New Jens Axboe 1 participant 1 message Feb 24 io_uring

lore
Share & tools
lore

Jens Axboe

author maintainer
#0 lore raw

PATCH 1/1 io_uring/cmd_net: use READ_ONCE() for ->addr3 read

Any SQE read should use READ_ONCE(), to ensure the result is read once and only once. Doesn't really matter for this case, but it's better to keep these 100% consistent and always use READ_ONCE() for the prep side of SQE handling.

Fixes 5d24321e4c15 ("io_uring: Introduce getsockname io_uring cmd")

---

io_uring/cmd_net.c +1 -1
index 57ddaf874611..125a81c520a6 100644
@@ -146,7 +146,7 @@ static int io_uring_cmd_getsockname(struct socket *sock,
 		return -EINVAL;
 
 	uaddr = u64_to_user_ptr(READ_ONCE(sqe->addr));
-	ulen = u64_to_user_ptr(sqe->addr3);
+	ulen = u64_to_user_ptr(READ_ONCE(sqe->addr3));
 	peer = READ_ONCE(sqe->optlen);
 	if (peer > 1)
 		return -EINVAL;
Signature · 1 line
Jens Axboe