Skip to contentSkip to conversation

capability: WARN when invalid capability is requested rather than BUG/panic

PATCH Bodo Eggert 1 participant 1 message Oct 1, 2008 9 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#9 lore raw
Quoted 6 lines · Eric Paris

Do we have any concern of a module being compiled against a new kernel say with cap number 35 defined and then loaded into a kernel with only 34 capabilities? Do we care about that forward compatibility? If we care BUG is scary. EPERM would be the right thing since clearly on this kernel the process can't possibly have cap #35.

Quoted 6 lines

We really have 4 options (in the order I like them).

1) do nothing (garbage in garbage out, sometimes panic sometimes not)
2) mask CAP_TO_INDEX (garbage in garbage out, no panic)
3) BUG_ON(!cap_valid(flag)) (garbage in BUG out, no panic)
4) WARN_ON/EPERM (garbage in EPERM out, no panic)

5) Use a macro or inline function to test for $cap <= $max_cap, eliminating the test in the final code.