Skip to contentSkip to conversation

New: buildroot-2017.08-rc1/toolchain/toolchain-wrapper.c:192]: (error) Memory leak:

Buildroot bugzilla at busybox.net 1 participant 2 messages Aug 9, 2017 – Aug 11, 2017

lore
Share & tools
lore
#0 lore raw

https://bugs.busybox.net/show_bug.cgi?id=10201

Bug ID: 10201
Summary: buildroot-2017.08-rc1/toolchain/toolchain-wrapper.c:19
2]: (error) Memory leak:
Product: buildroot
Version: unspecified
Hardware: All
OS: Linux
Status: NEW
Severity: minor
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: dcb314 at hotmail.com
CC: buildroot at uclibc.org
Target Milestone: ---

Source code is

        basename = progpath;
        absbasedir = malloc(PATH_MAX + 1);
        ret = readlink("/proc/self/exe", absbasedir, PATH_MAX);
        if (ret < 0) {
            perror(__FILE__ ": readlink");
            return 2;
        }

Probably not worth much, but a call to free would shut up the static analyser.

Signature · 2 lines
You are receiving this mail because:
You are on the CC list for the bug.
#1 lore raw

[Buildroot] [Bug 10201] buildroot-2017.08-rc1/toolchain/toolchain-wrapper.c:192]: (error) Memory leak:

https://bugs.busybox.net/show_bug.cgi?id=10201

Arnout Vandecappelle <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #1 from Arnout Vandecappelle <[email protected]> --- Your static analyser is weird, because there are a few other things which aren't freed either: relbasedir, absbasedir in different code paths.

However, we do this by choice. Freeing things before exiting is useless, since the OS will implicitly free everything when the program exits. That's why e.g. valgrind doesn't report these as real memory leaks (because they are still reachable).

So no, this is not a memory leak.

For consistency, the free(args) at the end should be removed, but that's a different issue.

Signature · 2 lines
You are receiving this mail because:
You are on the CC list for the bug.