New: package/x11r7/mcookie/mcookie.c:207: bad size ?

https://bugs.busybox.net/show_bug.cgi?id=10216

Bug ID: 10216
Summary: package/x11r7/mcookie/mcookie.c:207: bad size ?
Product: buildroot
Version: unspecified
Hardware: All
OS: Linux
Status: NEW
Severity: minor
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: dcb314 at hotmail.com
CC: buildroot at uclibc.org
Target Milestone: ---

buildroot-2017.08-rc1/package/x11r7/mcookie/mcookie.c:207]: (warning) Size of pointer 'ctx' used instead of size of its data.

Source code is

memset(ctx, 0, sizeof(ctx)); /* In case it's sensitive */

Maybe better code

memset(ctx, 0, sizeof(*ctx)); /* In case it's sensitive */

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=10216

Bernd Kuhls <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

           Assignee|unassigned at buildroot.uclibc |bernd.kuhls at t-online.de
                   |.org                        |
             Status|NEW                         |ASSIGNED

--- Comment #1 from Bernd Kuhls <[email protected]> --- Thanks to your bug report I noticed that mcookie is part of util-linux:
https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/tree/misc-utils

Therefore I plan to submit a patch to buildroot that removes the mcookie package in favour of util-linux which actively maintains mcookie:
https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/log/misc-utils/mcookie.c

If your bug report is still valid with upstream then please send your bug report to https://github.com/karelzak/util-linux

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=10216

--- Comment #2 from Peter Korsgaard <[email protected]> --- FYI, this specific issue was fixed upstream (util-linux) back in 2009:

https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/commit/lib/md5.c?id=6596057175c6ed342dc20e85eae8a42eb29b629f

I'll fix up our embedded mcookie.c copy as well for 2017.02.7 and 2017.08.1. Moving forward, it indeed makes more sense to use the util-linux version.

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=10216

--- Comment #3 from Thomas Petazzoni <[email protected]> --- (In reply to Bernd Kuhls from comment #1)
Bernd, did you ever got around to submitting the patch removing the mcookie package, and switching to the one from util-linux instead?

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=10216

Peter Korsgaard <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Peter Korsgaard <[email protected]> --- Fixed by
https://git.buildroot.org/buildroot/commit/?id=40f4191f2a1246b792ffc0c02b6c9bd2d62649f2,
thanks

You are receiving this mail because:
You are on the CC list for the bug.