Skip to contentSkip to conversation

New: Incorrect RFC section reference in comment

Bugme-new New Andrew Morton 2 participants 2 messages May 7, 2008 1 message not in the archive

Subsystems (3)
Networking Network drivers IPv4/IPv6
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]/

Andrew Morton

author
#1 lore raw

(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface).

Quoted 37 lines · On Tue, 6 May 2008 23:25:14 -0700 (PDT) [email protected] wrote:

http://bugzilla.kernel.org/show_bug.cgi?id=10611

Summary: Incorrect RFC section reference in comment
Product: Networking
Version: 2.5
KernelVersion: master branch
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: IPV4
AssignedTo: [email protected]
ReportedBy: [email protected]

Problem Description:

RFC 1122 does not have a section 3.1.2.2. The requirement to silently discard packets with a bad checksum is in section 3.2.1.2 instead.

Proposed patch:

net/ipv4/ip_input.c +0 -1
index 212734c..5bdb8f4 100644
@@ -394,7 +394,7 @@ int ip_rcv(struct sk_buff *skb, struct net_device *dev,
 struct packet_type *pt,
        iph = skb->nh.iph;
 
        /*
-        *      RFC1122: 3.1.2.2 MUST silently discard any IP frame that fails

the checksum.
+ * RFC1122: 3.2.1.2 MUST silently discard any IP frame that fails
the checksum.

Quoted 5 lines
         *
         *      Is the datagram acceptable?
         *

Thanks, but we much prefer that patches be handled via email. Can you please resend the patch as a reply-to-all to this email, along with a
signed-off-by: as per Documentation/SubmittingPatches?

#2 lore raw

PATCH 1/1 net/ipv4: Correct RFC 1122 section reference in comment

From: J.H.M. Dassen (Ray) <[email protected]>

RFC 1122 does not have a section 3.1.2.2. The requirement to silently discard datagrams with a bad checksum is in section 3.2.1.2 instead.

Signed-off-by J.H.M. Dassen (Ray) <[email protected]>

---

Previously submitted as http://bugzilla.kernel.org/show_bug.cgi?id=10611

net/ipv4/ip_input.c +1 -1
index 212734c..5bdb8f4 100644
@@ -394,7 +394,7 @@ int ip_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt,
 	iph = skb->nh.iph;
 
 	/*
-	 *	RFC1122: 3.1.2.2 MUST silently discard any IP frame that fails the checksum.
+	 *	RFC1122: 3.2.1.2 MUST silently discard any IP frame that fails the checksum.
 	 *
 	 *	Is the datagram acceptable?
 	 *
Signature · 4 lines
LEADERSHIP  A form of self-preservation exhibited by people with auto-
destructive imaginations in order to ensure that when it comes to the crunch
it'll be someone else's bones which go crack and not their own.
    - The Hipcrime Vocab by Chad C. Mulligan