New: /etc/init.d/S29netplug starts multiple instances of netplugd

https://bugs.busybox.net/show_bug.cgi?id=10661

Bug ID: 10661
Summary: /etc/init.d/S29netplug starts multiple instances of
netplugd
Product: buildroot
Version: 2017.11.2
Hardware: All
OS: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: mail2k at web.de
CC: buildroot at uclibc.org
Target Milestone: ---

If you execute the command "/etc/init.d/S29netplug start" multiple times, you get multiple instances of netplugd.
This is not the desired behaviour. We should only have one running netplugd.

The change has to be made in package/netplug/S29netplug:
line 46:
- start-stop-daemon -S -q -p /var/run/netplugd.pid -x /sbin/netplugd
${NETPLUGDARGS}

+ start-stop-daemon -S -q -x /sbin/netplugd -- -p /var/run/netplugd.pid
${NETPLUGDARGS}

Reason:
If the start-stop-daemon gets the parameter -p /var/run/netplug.pid it will try to identify a running process by this pid-file but the file doesn't exist. As a result, every call of "/etc/init.d/S29netplug start" starts a new netplugd.

--> The parameter -p /var/run/netplug.pid must be passed to netplugd.

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=10661

Thomas Petazzoni <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at buildroot.uclibc |casantos at datacom.ind.br
|.org |

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=10661

Carlos Santos <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED

--- Comment #1 from Carlos Santos <[email protected]> --- I'm taking this.

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=10661

Carlos Santos <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #2 from Carlos Santos <[email protected]> --- Patch submitted: https://patchwork.ozlabs.org/patch/926080/

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=10661

Carlos Santos <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |TEST-REQUEST

--- Comment #3 from Carlos Santos <[email protected]> --- (In reply to Carlos Santos from comment #2)

Applied to master (commit 3c6a5bdd3ed94f97afe2db9123d7117f85f654ce). Please test it and change the bug status to VERIFIED on success; otherwise report additional findings and change the status to REOPENED.

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=10661

Carlos Santos <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

         Resolution|TEST-REQUEST                |FIXED
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Carlos Santos <[email protected]> --- Closing, since the OP did not answer and nobody reported regressions.

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=10661

--- Comment #5 from mail2k at web.de ---
Sorry for answering so late. I was offline for a while. Thank you for fixing the bug.
Works perfect now.

You are receiving this mail because:
You are on the CC list for the bug.