Skip to contentSkip to conversation

[20.11] meson compatibility regression

Bug 1088 [email protected] 1 participant 1 message Sep 30, 2022

lore
Share & tools
lore

[email protected]

author Tested-by Jerin Jacob
#0 lore raw

https://bugs.dpdk.org/show_bug.cgi?id=1088

            Bug ID: 1088
           Summary: [20.11] meson compatibility regression
           Product: DPDK
           Version: 20.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: meson
          Assignee: [email protected]
          Reporter: [email protected]

Target Milestone: ---

DPDK 20.11 supports meson 0.47.1 as per:
http://doc.dpdk.org/guides-20.11/prog_guide/build-sdk-meson.html#getting-the-tools

The compatibility was found to be broken by the OVS CI when attempting to upgrade OVS to use 20.11.6 and reported here:
https://mail.openvswitch.org/pipermail/ovs-dev/2022-September/397953.html

David ID'd and reported the following commit as the offender:

commit 14421740c492df1d9267892566ef33e784790c1c

Author: Bruce Richardson <[email protected]>
Date:   Thu Jan 20 18:06:39 2022 +0000

build: fix warnings when running external commands

[ upstream commit ecb904cc4596b33aa182e2a7c9edc3104ff981c3 ]

Meson 0.61.1 is giving warnings that the calls to run_command do not always explicitly specify if the result is to be checked or not, i.e. there is a missing "check" parameter. This is because the default behaviour without the parameter is due to change in the future.

We can fix these warnings by explicitly adding into each call whether the result should be checked by meson or not. This patch therefore adds in "check: false" to each run_command call where the result is being checked by the DPDK meson.build code afterwards, and adds in "check: true" to any calls where the result is currently unchecked.

Bugzilla ID: 921

Signature · 2 lines
You are receiving this mail because:
You are the assignee for the bug.