New: Git package binaries are ~180MB (compared to ~20MB in stable branches).
https://bugs.busybox.net/show_bug.cgi?id=11046
Bug ID: 11046
Summary: Git package binaries are ~180MB (compared to ~20MB in
stable branches).
Product: buildroot
Version: unspecified
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: paulstewartis at gmail.com
CC: buildroot at uclibc.org
Target Milestone: ---
Created attachment 7601
--> https://bugs.busybox.net/attachment.cgi?id=7601&action=edit
Test config from Y Morin.
When I build a config with git enabled with 2018.05-rc2 the git binaries in /usr/libexec/git-core are over 180MB. When I build the same config with 2018.02.2 (and all other stable versions I have used over the last few years) the binaries are ~20MB or less.
Steps to reproduce:
1. Check out 2018.02.2 from git repo
2. Build the attached config.
3. Examine the git-core folder in the image tar file.
4. Check out 2018.05-rc2 from git repo
5. Build the attached config.
6. Examine the git-core folder in the image tar file.
My build system is openSUSE Leap 42.3 fully patched.
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 11046] Git package binaries are ~180MB (compared to ~20MB in stable branches).
https://bugs.busybox.net/show_bug.cgi?id=11046
--- Comment #1 from Arnout Vandecappelle <[email protected]> ---
I was not able to reproduce the issue with the given config. The executables are all hardlinked with eachother in both versions.
Are you sure you don't have some post-image script that clones the hardlinks?
I suspected patchelf as a potential culprit, but it does open(fileName, O_TRUNC | O_WRONLY) which should preserve hardlinks (as proven by bug 11031).
Can you check if the copies are made during the install of git itself, or during the target-finalize step, or maybe even during rootfs generation?
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 11046] Git package binaries are ~180MB (compared to ~20MB in stable branches).
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=11046
--- Comment #2 from Paul Stewart <[email protected]> --- (In reply to Arnout Vandecappelle from comment #1)
The post scripts only run if they are called out in the config, right? Either way, none of my scripts do anything with git. I can definitely reproduce with the attached, minimal, config.
The binaries are normal in target/usr/libexec/git-core. So I think you're on the right track.
What's the best way for me to determine: "if the copies are made during the install of git itself, or during the target-finalize step, or maybe even during rootfs generation"?
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 11046] Git package binaries are ~180MB (compared to ~20MB in stable branches).
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=11046
--- Comment #3 from Peter Korsgaard <[email protected]> ---
(In reply to Paul Stewart from comment #2)
# The binaries are normal in target/usr/libexec/git-core. So I think you're on the right track.
Ahh, now we are talking. This I can reproduce:
du -hs target images/rootfs.tar
17M target
191M images/rootfs.tar
I will take a closer look and see where this comes from.
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 11046] Git package binaries are ~180MB (compared to ~20MB in stable branches).
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=11046
Peter Korsgaard <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #4 from Peter Korsgaard <[email protected]> ---
This was indeed caused by a recent change to make a copy of output/target before running the file system hooks and generate file systems, and this copy used rsync without the -H (preserve hard links) option.
I have sent a patch to fix it:
http://patchwork.ozlabs.org/patch/921203/
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 11046] Git package binaries are ~180MB (compared to ~20MB in stable branches).
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=11046
Peter Korsgaard <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED--- Comment #5 from Peter Korsgaard <[email protected]> --- Fixed by:
https://git.buildroot.org/buildroot/commit/?id=065e7672e1e933f8b5257eddc9d1d8b7021a1687
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.