Skip to contentSkip to conversation

New: Latest master fails to build readline with RELRO FULL

Buildroot bugzilla at busybox.net 1 participant 3 messages Sep 11, 2018 – Nov 2, 2018

lore
Share & tools
lore
#0 lore raw

https://bugs.busybox.net/show_bug.cgi?id=11321

Bug ID: 11321
Summary: Latest master fails to build readline with RELRO FULL
Product: buildroot
Version: unspecified
Hardware: All
OS: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: tpearson at raptorengineering.com
CC: buildroot at uclibc.org
Target Milestone: ---

When RELRO is set to Full, readline fails to build. RELRO Partial has no issues.

/home/buildroot/project/buildroot# make

Quoted 1 line
Quoted 1 line
Quoted 1 line

readline 7.0 Building

PATH="/home/buildroot/project/buildroot/output/host/bin:/home/buildroot/project/buildroot/output/host/sbin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
/usr/bin/make -j16 -C
/home/buildroot/project/buildroot/output/build/readline-7.0/
make[1]: Entering directory
'/home/buildroot/project/buildroot/output/build/readline-7.0'
test -d shlib || mkdir shlib
( cd shlib ; /usr/bin/make -w -j --jobserver-fds=3,4 all )
make[2]: Entering directory
'/home/buildroot/project/buildroot/output/build/readline-7.0/shlib'
rm -f libreadline.so.7.0
rm -f libhistory.so.7.0
/home/buildroot/project/buildroot/output/host/bin/powerpc64le-buildroot-linux-gnu-gcc
-shared -Wl,-soname,libreadline.so.7.0 -pie -Wl,-z,now -Wl,-z,relro
-Wl,-rpath,/usr/lib -Wl,-soname,basename libreadline.so.7.0 .0 -o
libreadline.so.7.0 readline.so vi_mode.so funmap.so keymaps.so parens.so
search.so rltty.so complete.so bind.so isearch.so display.so signals.so util.so
kill.so undo.so macro.so input.so callback.so terminal.so text.so nls.so
misc.so history.so histexpand.so histfile.so histsearch.so shell.so mbutil.so
tilde.so colors.so parse-colors.so xmalloc.so xfree.so compat.so -lncurses /home/buildroot/project/buildroot/output/host/bin/powerpc64le-buildroot-linux-gnu-gcc
-shared -Wl,-soname,libhistory.so.7.0 -pie -Wl,-z,now -Wl,-z,relro
-Wl,-rpath,/usr/lib -Wl,-soname,basename libhistory.so.7.0 .0 -o
libhistory.so.7.0 history.so histexpand.so histfile.so histsearch.so shell.so
mbutil.so xmalloc.so xfree.so -lncurses /home/buildroot/project/buildroot/output/host/lib/gcc/powerpc64le-buildroot-linux-gnu/8.2.0/../../../../powerpc64le-buildroot-linux-gnu/bin/ld:
/home/buildroot/project/buildroot/output/host/powerpc64le-buildroot-linux-gnu/sysroot/usr/lib/../lib64/Scrt1.o:(.data.rel.ro.local+0x8):
undefined reference to `main'
collect2: error: ld returned 1 exit status
Makefile:180: recipe for target 'libhistory.so.7.0' failed
make[2]: *** [libhistory.so.7.0] Error 1
make[2]: *** Waiting for unfinished jobs.... /home/buildroot/project/buildroot/output/host/lib/gcc/powerpc64le-buildroot-linux-gnu/8.2.0/../../../../powerpc64le-buildroot-linux-gnu/bin/ld:
/home/buildroot/project/buildroot/output/host/powerpc64le-buildroot-linux-gnu/sysroot/usr/lib/../lib64/Scrt1.o:(.data.rel.ro.local+0x8):
undefined reference to `main'
collect2: error: ld returned 1 exit status
Makefile:176: recipe for target 'libreadline.so.7.0' failed
make[2]: *** [libreadline.so.7.0] Error 1
make[2]: Leaving directory
'/home/buildroot/project/buildroot/output/build/readline-7.0/shlib'
Makefile:209: recipe for target 'shared' failed
make[1]: *** [shared] Error 2
make[1]: Leaving directory
'/home/buildroot/project/buildroot/output/build/readline-7.0'
package/pkg-generic.mk:229: recipe for target
'/home/buildroot/project/buildroot/output/build/readline-7.0/.stamp_built'
failed
make: ***
[/home/buildroot/project/buildroot/output/build/readline-7.0/.stamp_built]
Error 2

Signature · 2 lines
You are receiving this mail because:
You are on the CC list for the bug.
#1 lore raw

[Buildroot] [Bug 11321] Latest master fails to build readline with RELRO FULL

https://bugs.busybox.net/show_bug.cgi?id=11321

--- Comment #1 from Matt Weber <[email protected]> --- Would you mind providing an example defconfig that reproduces this? I'm working on an update to the hardening approach, as there are link time issues with the way the current flags are included. This maybe related to your issue and I'll give it a test.

Signature · 2 lines
You are receiving this mail because:
You are on the CC list for the bug.
#2 lore raw

[Buildroot] [Bug 11321] Latest master fails to build readline with RELRO FULL

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=11321

Thomas Petazzoni <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Thomas Petazzoni <[email protected]> --- This is fixed by the patches from Matt that add hardening awareness in the toolchain wrapper, and which have been merged in master as of:

394bdd11fc1f741c88c89f0e71571d87a29ab627 BR2_FORTIFY*: toolchain wrapper limitation note
f10822d151085bcbfecd0ecf2542ac5f5623fd9d toolchain/toolchain-wrapper: add BR2_SSP_* support
7484c1c3b8065d6f2f5a67607e9917ecfea022eb toolchain/toolchain-wrapper: add BR2_RELRO_

Signature · 2 lines
You are receiving this mail because:
You are on the CC list for the bug.