Skip to contentSkip to conversation

New: Automate "to compile as module" strings

Bugme-new Andrew Morton 1 participant 1 message Aug 28, 2008 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]/

#1 lore raw
Quoted 26 lines · On Thu, 28 Aug 2008 09:24:42 -0700 (PDT) [email protected] wrote:

http://bugzilla.kernel.org/show_bug.cgi?id=11446

           Summary: Automate "to compile as module" strings
           Product: Other
           Version: 2.5
     KernelVersion: 2.6.27
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: enhancement
          Priority: P1
         Component: Configuration
        AssignedTo: [email protected]
        ReportedBy: [email protected]

I've spent quite a bit of time scanning through Kconfig files correcting various textual errors. One thing that I've noticed is variations of "To compile X as a module, choose M here. The module will be called Y" occur extremely frequently. A quick grep of the current mainline actually reveals ~1192 instances of it. It seems very redundant to me to have everyone who adds a module or feature copy and paste this text, when it could seemingly be dynamically generated with ease.

Quoted 2 lines

Is there any reason we can't simply standardize on one string, and display it for any component that has the module option available?

Good point :)

The Kconfig system doesn't presently know the name of the module, but that could be added. eg:

config BMAC

	tristate "BMAC (G3 ethernet) support"
	depends on PPC_PMAC && PPC32

+ modulename bmac
select CRC32
help
Say Y for support of BMAC Ethernet interfaces. These are used on G3 computers.

- To compile this driver as a module, choose M here: the module
- will be called bmac.

Any sane organisation would look at the benefit of this, weigh that against the massive amount of code churn and would then run away howling.