New: Bugs in support/scripts/apply-patches.sh
https://bugs.busybox.net/show_bug.cgi?id=11931
Bug ID: 11931
Summary: Bugs in support/scripts/apply-patches.sh
Product: buildroot
Version: 2019.02.2
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: escape at linux.alibaba.com
CC: buildroot at uclibc.org
Target Milestone: ---
Created attachment 8076
--> https://bugs.busybox.net/attachment.cgi?id=8076&action=edit
patch to fix this bug
Code line 120 to line 128 is to check whether the patch containing "rename from" and "rename to". But it directly use grep to find, ignoring the patch may be a tar file or else. It can only work on patch of textfile form. Besides, if version of patch is higher than 2.7, rejecting patches containing "rename from" and "rename to" is unnecessary, because it can work correctly. So it should check verison of patch first than unpack the patch to find whether it contains "rename from"
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 11931] Bugs in support/scripts/apply-patches.sh
https://bugs.busybox.net/show_bug.cgi?id=11931
--- Comment #1 from Thomas Petazzoni <[email protected]> --- Thanks for the bug report! We do not want to rely on the patch version though. Indeed, what if someone that has a patch > = 2.7 on his machine adds a patch using renames to Buildroot, which gets committed, and then this Buildroot gets used by someone having a patch < 2.7 on his machine ? The build will break. So clearly, we should not make it behave differently depending on the patch version.
The uncompression part is correct though. Would you mind submitting it as a proper patch to the Buildroot mailing list, with a commit log and Signed-off-by, so that we can apply it ? Thanks!
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 11931] Bugs in support/scripts/apply-patches.sh
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=11931
Thomas Petazzoni <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED--- Comment #2 from Thomas Petazzoni <[email protected]> --- Fixed by
https://git.buildroot.org/buildroot/commit/?id=35c3a1e6937dc08157075027bf6219157510b2f9.
Thanks!
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.