Skip to contentSkip to conversation

In ixgbe_tx_free_bufs function the variable free on stack is used before initialization

Bug 121 [email protected] 1 participant 1 message Dec 7, 2018

lore
Share & tools
lore
#0 lore raw

https://bugs.dpdk.org/show_bug.cgi?id=121

Bug ID: 121
Summary: In ixgbe_tx_free_bufs function the variable free on
stack is used before initialization
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: CONFIRMED
Severity: normal
Priority: Normal
Component: core
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: ---

static __rte_always_inline int
ixgbe_tx_free_bufs(struct ixgbe_tx_queue *txq)
{
....

    struct rte_mbuf *m, *free[RTE_IXGBE_TX_MAX_FREE_BUF_SZ];

....

       if (nb_free >= RTE_IXGBE_TX_MAX_FREE_BUF_SZ ||
            (nb_free > 0 && m->pool != free[0]->pool)) { <---free[0] is from
the stack
            rte_mempool_put_bulk(free[0]->pool,
                         (void **)free, nb_free);
            nb_free = 0;
        }

        free[nb_free++] = m;  <-- free is set later
}
Signature · 2 lines
You are receiving this mail because:
You are the assignee for the bug.