Skip to contentSkip to conversation

New: kernel headers not correctly installed into toolchain/staging

Buildroot bugzilla at busybox.net 1 participant 4 messages Mar 2, 2010 – Apr 3, 2010

lore
Share & tools
lore
#0 lore raw

https://bugs.busybox.net/show_bug.cgi?id=1219

Summary: kernel headers not correctly installed into
toolchain/staging
Product: buildroot
Version: unspecified
Platform: PC
OS/Version: Windows
Status: NEW
Severity: normal
Priority: P5
Component: Other
AssignedTo: unassigned at buildroot.uclibc.org
ReportedBy: will_wagner at carallon.com
CC: buildroot at uclibc.org
Estimated Hours: 0.0

Currently not all the kernel headers are installed into staging. This is because of old code in uclibc.mk that relates to 2.4 kernels.

Looking at uclibc.mk, the problem seems to happen three times, first copying into $(TOOLCHAIN_DIR)/uClibc_dev/usr/include, then into $(STAGING_DIR)/usr/include and finally into $(TARGET_DIR)/usr/include (only if libc.a is on target)

All of these cases have different behavior depending on whether ifeq ($(LINUX_HEADERS_IS_KERNEL),y) is true. If it is it just copies all the files, otherwise it picks out a specific subset. However in a search of all the buildroot files LINUX_HEADERS_IS_KERNEL is never mentioned except in uclibc.mk

Looking back through earlier buildroot versions, Peter removed the last mention to LINUX_HEADERS_IS_KERNEL with this commit to remove 2.4.x kernel header support http://lists.busybox.net/pipermail/buildroot/2009-February/026144.html

It appears that before this LINUX_HEADERS_IS_KERNEL was set true for 2.6.x and false for 2.4.x. It looks to me like that change broke the copying of kernel headers for 2.6.x and left code in uclibc.mk that was meant for 2.4.x headers.

This issue has come up on the list a number of times with people complaining about a lack of mtd/mtd.h

Attached patch fixes the issue.

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#1 lore raw

[Buildroot] [Bug 1219] kernel headers not correctly installed into toolchain/staging

https://bugs.busybox.net/show_bug.cgi?id=1219

--- Comment #1 from Will Wagner <[email protected]> 2010-03-02 12:46:06 UTC --- Created an attachment (id=1183)
--> (https://bugs.busybox.net/attachment.cgi?id=1183)
Fix for copying kernel headers

Helps if I attach the patch...

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
author Acked-by Thomas Petazzoni
#2 lore raw

[Buildroot] [Bug 1219] kernel headers not correctly installed into toolchain/staging

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=1219

Thomas Petazzoni <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |2010.05

--- Comment #2 from Thomas Petazzoni <[email protected]> 2010-03-02 13:10:47 UTC ---

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#3 lore raw

[Buildroot] [Bug 1219] kernel headers not correctly installed into toolchain/staging

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=1219

Peter Korsgaard <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Peter Korsgaard <[email protected]> 2010-04-03 08:31:30 UTC --- Committed, sorry for the slow response

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.