Skip to contentSkip to conversation

New: Spinning up disk is observed on standby paths until timeout, resulting in longer path restoration time.

Bug 12742 [email protected] 2 participants 3 messages Feb 20, 2009 – Apr 6, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

http://bugzilla.kernel.org/show_bug.cgi?id=12742

Summary: Spinning up disk is observed on standby paths until
timeout, resulting in longer path restoration time.
Product: SCSI Drivers
Version: 2.5
KernelVersion: 2.6.27
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: high
Priority: P1
Component: Other
AssignedTo: [email protected]
ReportedBy: [email protected]

Latest working kernel version: 2.6.27
Earliest failing kernel version:
Distribution: suse
Hardware Environment:x86_64
Software Environment:sd
Problem Description:

Steps to reproduce:
1. present a standby lun to the host
2. do a discovery from the host (scan the scsi bus)
3. Spinning of disks is observed in /var/log/messages

Whenever a device goes offline and comes back, the new sd device takes longer time to get created. This is because of the spinning up of disk in sd_spinup_disk fuction as the standby paths would return device not ready with 0x04/0x0b asc/ascq.

recommended patch :
diff -pNaur /usr/src/linux/drivers/scsi/sd.c sd.c

sd.c 2009-02-19 16:39:16.000000000 +0530 renamed from usr/src/linux/drivers/scsi/sd.c 2009-02-09 22:24:56.000000000 +0530 +1 -2
@@ -1181,8 +1181,8 @@ sd_spinup_disk(struct scsi_disk *sdkp)
                 */
                if (sense_valid &&
                    sshdr.sense_key == NOT_READY &&
-                   sshdr.asc == 4 && sshdr.ascq == 3) {
-                       break;          /* manual intervention required */
+                   sshdr.asc == 4 && (sshdr.ascq == 3 || sshdr.ascq == 0x0b ||

sshdr.ascq == 0x0c) ) {
+ break; /* manual intervention required || Standby ||
Unavailable */

/*
* Issue command to spin up drive when not ready

Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
#1 lore raw

[Bug 12742] Spinning up disk is observed on standby paths until timeout, resulting in longer path restoration time.

http://bugzilla.kernel.org/show_bug.cgi?id=12742

------- Comment #1 from [email protected] 2009-02-20 02:26 ------- Please submit patches via email, as per Documentation/SubmittingPatches.

Please send this one to

[email protected]
[email protected]

Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
#2 lore raw

[Bug 12742] Spinning up disk is observed on standby paths until timeout, resulting in longer path restoration time.

In reply to [email protected]

http://bugzilla.kernel.org/show_bug.cgi?id=12742

Narayanan <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|                            |CODE_FIX
         Regression|---                         |No

--- Comment #2 from Narayanan <[email protected]> 2009-04-06 08:52:07 --- code fix is available in 2.6.29-1

Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.