New: RPI-firmware package: DTB-overlay dependency

https://bugs.busybox.net/show_bug.cgi?id=12831

Bug ID: 12831
Summary: RPI-firmware package: DTB-overlay dependency
Product: buildroot
Version: 2020.02.1
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: melanie at trash-mail.com
CC: buildroot at uclibc.org
Target Milestone: ---

The config option 'BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS' currently depends on 'BR2_LINUX_KERNEL_DTS_SUPPORT'.

In my opinion this dependency should be changed from 'BR2_LINUX_KERNEL_DTS_SUPPORT' to 'BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT'.

This change would make sure that the DTB-overlays are downloaded/installed only if DTB-overlay support has been selected for the target system.

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=12831

--- Comment #1 from Peter Seiderer <[email protected]> ---
Right and wrong at the same time, in principle your are right, but the raspberrypi linux-kernel 32-bit seems to enable the overlay support auto-magical,
only for the 64-bit versions an explicit BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT is needed (did not test with mainline kernels)..., see e.g. [1], [2] and [3]

[1] http://lists.busybox.net/pipermail/buildroot/2019-November/265550.html
[2] http://lists.busybox.net/pipermail/buildroot/2019-November/265772.html
[3]
https://git.buildroot.net/buildroot/commit/?id=2aa92335cdc5f71c2d09391dc49fcf3c7627d6f0

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=12831

--- Comment #2 from Melanie <[email protected]> --- Okay interesting, thanks for the explanation. Do you prefer to keep it as is?

After reading the links in your comment, I still believe that changing the dependency to 'BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT' (and enabling this config option in all raspberrypi-defconfigs) is a more "correct" approach ...

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=12831

--- Comment #3 from Thomas Petazzoni <[email protected]> ---
I have submitted
https://patchwork.ozlabs.org/project/buildroot/patch/20200516140221.1464063-1-thomas.petazzoni at bootlin.com/ to fix this issue.

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=12831

Yann E. MORIN <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |yann.morin.1998 at free.fr

--- Comment #4 from Yann E. MORIN <[email protected]> --- Melanie, All,

Fixed with chagnes from Thomas:

https://git.buildroot.org/buildroot/commit/?id=9fd1d4fec1c88f9f3f4e41f9b6dc8a740538217b

Thanks for the report.

Regards,
Yann E. MORIN.

You are receiving this mail because:
You are on the CC list for the bug.