New: [bonding] xmit hash policy doesn't recognize vlan tagged and PPPoE frames

Bugme-new Andrew Morton 1 participant 1 message Apr 9, 2009 1 message not in the archive

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]/

Andrew Morton

author

2009-04-09 21:13 UTC #1 lore raw

(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface).

Quoted 28 lines · On Fri, 3 Apr 2009 16:34:24 GMT [email protected] wrote:

http://bugzilla.kernel.org/show_bug.cgi?id=13004
Summary: [bonding] xmit hash policy doesn't recognize vlan
tagged and PPPoE frames
Product: Networking
Version: 2.5
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: Other
AssignedTo: [email protected]
ReportedBy: [email protected]
Regression: No
Hi,
there is a problem with xmit hash policy in bonding driver. It doesn't work when using layer 2+3 or 3+4 policy on vlan tagged or PPPoE frames. Functions bond_xmit_hash_policy_l23() and bond_xmit_hash_policy_l34() check if frame ethertype is ETH_P_IP and unless, it fall back to layer 2 hashing. It additionally should check, if frame ethertype is ETH_P_8021Q or ETH_P_PPP_SES and embedded type is ETH_P_IP and if so, also treat it as IP packet.

Quoted 2 lines

Appropriate patch in attachment.

Jay, there's a patch in there.

Adam, please prefer to submit patches via email as per Documentation/SubmittingPatches rather than via bugzilla, thanks.